Add unit tests for base::GetSystemMemoryInfo

base/process_util_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #define _CRT_SECURE_NO_WARNINGS
 
 #include <limits>
 
 #include "base/command_line.h"
 #include "base/debug/alias.h"
@@ skipping 362 matching lines @@
   EXPECT_TRUE(process.SetProcessBackgrounded(false));
   EXPECT_FALSE(process.IsProcessBackgrounded());
 #else
   process.SetProcessBackgrounded(true);
   process.SetProcessBackgrounded(false);
 #endif
   int new_priority = process.GetPriority();
   EXPECT_EQ(old_priority, new_priority);
 }
 
+#if defined(OS_LINUX) || defined(OS_ANDROID)
+TEST_F(ProcessUtilTest, GetSystemMemoryInfo) {
+  base::SystemMemoryInfoKB info1;

[jar (doing other things), 2013/02/14 02:26:11]

nit: how about using the name |info|.

I assume you used to have others.

+  EXPECT_TRUE(base::GetSystemMemoryInfo(&info1));
+
+  // Ensure each field received a value.
+  EXPECT_GT(info1.total, 0);
+  EXPECT_GT(info1.free, 0);
+  EXPECT_GT(info1.buffers, 0);
+  EXPECT_GT(info1.cached, 0);
+  EXPECT_GT(info1.active_anon, 0);
+  EXPECT_GT(info1.inactive_anon, 0);
+  EXPECT_GT(info1.active_file, 0);
+  EXPECT_GT(info1.inactive_file, 0);
+
+  // All the values should be less than the total amount of memory.
+  EXPECT_LT(info1.free, info1.total);
+  EXPECT_LT(info1.buffers, info1.total);
+  EXPECT_LT(info1.cached, info1.total);
+  EXPECT_LT(info1.active_anon, info1.total);
+  EXPECT_LT(info1.inactive_anon, info1.total);
+  EXPECT_LT(info1.active_file, info1.total);
+  EXPECT_LT(info1.inactive_file, info1.total);
+
+#if defined(OS_CHROMEOS)
+  // Chrome OS exposes shmem.
+  EXPECT_GT(info1.shmem, 0);
+  EXPECT_LT(info1.shmem, info1.total);
+  // Chrome unit tests are not run on actual Chrome OS hardware, so gem_objects
+  // and gem_size cannot be tested here.
+#endif
+}
+#endif  // defined(OS_LINUX) || defined(OS_ANDROID)
+
 // TODO(estade): if possible, port these 2 tests.
 #if defined(OS_WIN)
 TEST_F(ProcessUtilTest, EnableLFH) {
   ASSERT_TRUE(base::EnableLowFragmentationHeap());
   if (IsDebuggerPresent()) {
     // Under these conditions, LFH can't be enabled. There's no point to test
     // anything.
     const char* no_debug_env = getenv("_NO_DEBUG_HEAP");
     if (!no_debug_env || strcmp(no_debug_env, "1"))
       return;
@@ skipping 842 matching lines @@
       SetUpInDeathAssert();
       while ((value_ = base::AllocatePsychoticallyBigObjCObject())) {}
     }, "");
 }
 
 #endif  // !ARCH_CPU_64_BITS
 #endif  // OS_MACOSX
 
 #endif  // !defined(OS_ANDROID) && !defined(OS_OPENBSD) &&
         // !defined(OS_WIN) && !defined(ADDRESS_SANITIZER)