Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(970)

Unified Diff: chrome/browser/extensions/chrome_extension_function_details.h

Issue 1225693009: Show extension uninstall dialog in browser window. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/chrome_extension_function_details.h
diff --git a/chrome/browser/extensions/chrome_extension_function_details.h b/chrome/browser/extensions/chrome_extension_function_details.h
index 2484158ff4dafd219f7fd8542df23eb2a19eec58..a57762e914a29f15203673005bbbd8a0b49ea69d 100644
--- a/chrome/browser/extensions/chrome_extension_function_details.h
+++ b/chrome/browser/extensions/chrome_extension_function_details.h
@@ -62,6 +62,13 @@ class ChromeExtensionFunctionDetails {
// contents then defaults to the foremost one.
content::WebContents* GetAssociatedWebContents();
+ // Gets the web contents if it's not from a background page. Otherwise this
not at google - send to devlin 2015/07/10 17:02:25 Actually can we call this method something with a
wjywbs 2015/07/10 19:54:22 I renamed this to be "GetOriginWebContents" becaus
+ // method will try to find the app's web contents by the extension id, or
+ // find the web contents from source_tab_id if it's not
+ // TabStripModel::kNoTab. If the web contents still can't be found, NULL will
+ // be returned.
+ content::WebContents* GetVisibleWebContents();
+
// Returns a pointer to the associated UIThreadExtensionFunction
UIThreadExtensionFunction* function() { return function_; }
const UIThreadExtensionFunction* function() const { return function_; }

Powered by Google App Engine
This is Rietveld 408576698