Show extension uninstall dialog in browser window.

chrome/browser/extensions/api/management/chrome_management_api_delegate.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/management/chrome_management_api_delegate.h"
 
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/extensions/bookmark_app_helper.h"
+#include "chrome/browser/extensions/chrome_extension_function_details.h"
 #include "chrome/browser/extensions/chrome_requirements_checker.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_util.h"
 #include "chrome/browser/extensions/launch_util.h"
 #include "chrome/browser/favicon/favicon_service_factory.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser_dialogs.h"
 #include "chrome/browser/ui/browser_finder.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/browser/ui/extensions/app_launch_params.h"
@@ skipping 51 matching lines @@
 
 class ManagementUninstallFunctionUninstallDialogDelegate
     : public extensions::ExtensionUninstallDialog::Delegate,
       public extensions::UninstallDialogDelegate {
  public:
   ManagementUninstallFunctionUninstallDialogDelegate(
       extensions::ManagementUninstallFunctionBase* function,
       const extensions::Extension* target_extension,
       bool show_programmatic_uninstall_ui)
       : function_(function) {
-    content::WebContents* web_contents = function->GetSenderWebContents();
+    Profile* profile = Profile::FromBrowserContext(function->browser_context());
+    content::WebContents* web_contents =
+        ChromeExtensionFunctionDetails(function).GetVisibleWebContents();

[not at google - send to devlin, 2015/07/10 17:02:25]

I'd slightly restructure this, to avoid the cast from BrowserContext->Profile
which already happens:

ChromeExtensionFunctionDetails details(function);
content::WebContents* web_contents = details.GetVisibleWebContents();
...
... chrome::FindBrowserWithProfile(details.GetProfile(), ...);
...

+    gfx::NativeWindow window =
+        web_contents ? web_contents->GetTopLevelNativeWindow() : nullptr;
+
+    if (!window) {
+      // This shouldn't happen if we have user gesture.
+      Browser* browser =
+          chrome::FindBrowserWithProfile(profile, chrome::GetActiveDesktop());

[not at google - send to devlin, 2015/07/10 17:02:25]

You could move this into GetNativeWindowForUI?

+      window = browser->window()->GetNativeWindow();
+    }
+
     extension_uninstall_dialog_.reset(
-        extensions::ExtensionUninstallDialog::Create(
-            Profile::FromBrowserContext(function->browser_context()),
-            web_contents ? web_contents->GetTopLevelNativeWindow() : nullptr,
-            this));
+        extensions::ExtensionUninstallDialog::Create(profile, window, this));
     if (show_programmatic_uninstall_ui) {
       extension_uninstall_dialog_->ConfirmUninstallByExtension(
           target_extension, function->extension(),
           extensions::UNINSTALL_REASON_MANAGEMENT_API);
     } else {
       extension_uninstall_dialog_->ConfirmUninstall(
           target_extension, extensions::UNINSTALL_REASON_MANAGEMENT_API);
     }
   }
   ~ManagementUninstallFunctionUninstallDialogDelegate() override {}
@@ skipping 214 matching lines @@
 
 GURL ChromeManagementAPIDelegate::GetIconURL(
     const extensions::Extension* extension,
     int icon_size,
     ExtensionIconSet::MatchType match,
     bool grayscale,
     bool* exists) const {
   return extensions::ExtensionIconSource::GetIconURL(extension, icon_size,
                                                      match, grayscale, exists);
 }