Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 1225683010: Add goma=on option to Makefile build. (Closed)

Created:
5 years, 5 months ago by rmcilroy
Modified:
5 years, 5 months ago
Reviewers:
Michael Achenbach
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add goma=on option to Makefile build. Committed: https://crrev.com/91255190eacceeaee35d530d96fcffd323e637ee Cr-Commit-Position: refs/heads/master@{#29551}

Patch Set 1 #

Total comments: 1

Patch Set 2 : goma=on instead #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M Makefile View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
rmcilroy
PTAL, thanks.
5 years, 5 months ago (2015-07-08 16:30:47 UTC) #2
Michael Achenbach
lgtm https://codereview.chromium.org/1225683010/diff/1/Makefile File Makefile (right): https://codereview.chromium.org/1225683010/diff/1/Makefile#newcode165 Makefile:165: ifeq ($(use_goma), on) how about just goma=on?
5 years, 5 months ago (2015-07-09 08:11:20 UTC) #3
rmcilroy
On 2015/07/09 08:11:20, Michael Achenbach wrote: > lgtm > > https://codereview.chromium.org/1225683010/diff/1/Makefile > File Makefile (right): ...
5 years, 5 months ago (2015-07-09 09:26:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1225683010/20001
5 years, 5 months ago (2015-07-09 09:27:22 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-09 09:50:53 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-07-09 09:51:10 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/91255190eacceeaee35d530d96fcffd323e637ee
Cr-Commit-Position: refs/heads/master@{#29551}

Powered by Google App Engine
This is Rietveld 408576698