When GrAAConvesTesselator was merging the first and last point of the array, it was deleting the la…

When GrAAConvesTesselator was merging the first and last point of the array, it was deleting the last point without checking to see if any of the previous points shared the same index. This led to continuing to use the index of a deleted point and thus referencing memory past the end of the vertex array.

BUG=chromium:505227
Committed: https://skia.googlesource.com/skia/+/0dacc6708d5db4fbe755d7b1d0716b51fe703058

[ethannicholas, 2015-07-07 18:29:58]

ethannicholas@google.com changed reviewers:
+ bsalomon@google.com, robertphillips@google.com

[robertphillips, 2015-07-07 18:50:54]

lgtm

https://codereview.chromium.org/1225683008/diff/1/src/gpu/GrAAConvexTessellat...
File src/gpu/GrAAConvexTessellator.cpp (right):

https://codereview.chromium.org/1225683008/diff/1/src/gpu/GrAAConvexTessellat...
src/gpu/GrAAConvexTessellator.cpp:685: dst[cur] = fused;
const ?

https://codereview.chromium.org/1225683008/diff/1/src/gpu/GrAAConvexTessellat...
src/gpu/GrAAConvexTessellator.cpp:686: int targetIdx = dst[cur - 1];
I would personally make this a for loop ...

[ethannicholas, 2015-07-07 19:27:42]

The CQ bit was checked by ethannicholas@google.com

[ethannicholas, 2015-07-07 19:27:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1225683008/#ps40001
(title: " ")

[commit-bot: I haz the power, 2015-07-07 19:27:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1225683008/40001

[commit-bot: I haz the power, 2015-07-07 19:41:55]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/0dacc6708d5db4fbe755d7b1d0716b51fe703058