Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 1225683004: [turbofan] Add new JSFrameSpecialization reducer. (Closed)

Created:
5 years, 5 months ago by Benedikt Meurer
Modified:
5 years, 5 months ago
Reviewers:
Jarin
CC:
v8-dev, Michael Starzinger, titzer, danno
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add new JSFrameSpecialization reducer. The JSFrameSpecialization specializes an OSR graph to the current unoptimized frame on which we will perform the on-stack replacement. This is used for asm.js functions, where we cannot reuse the OSR code object anyway because of context specialization, and so we could as well specialize to the max instead. It works by replacing all OsrValues in the graph with their values in the JavaScriptFrame. The idea is that using this trick we get better performance without doing the unsound backpropagation of types to OsrValues later. This is the first step towards fixing OSR for TurboFan. R=jarin@chromium.org BUG=v8:4273 LOG=n Committed: https://crrev.com/b0a852e8c2ce2add1ba8a26d572aff39af0968a3 Cr-Commit-Position: refs/heads/master@{#29476}

Patch Set 1 #

Patch Set 2 : Also specialize Parameters as discussed with Jaro. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -21 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler.h View 6 chunks +22 lines, -12 lines 0 comments Download
M src/compiler.cc View 4 chunks +7 lines, -2 lines 0 comments Download
A src/compiler/js-frame-specialization.h View 1 1 chunk +44 lines, -0 lines 0 comments Download
A src/compiler/js-frame-specialization.cc View 1 1 chunk +69 lines, -0 lines 0 comments Download
M src/compiler/pipeline.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M src/runtime/runtime-compiler.cc View 2 chunks +9 lines, -7 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Benedikt Meurer
5 years, 5 months ago (2015-07-06 07:00:44 UTC) #1
Benedikt Meurer
Hey Jaro, First step for OSR fixup. Just adds the additional specialization as discussed offline. ...
5 years, 5 months ago (2015-07-06 07:02:12 UTC) #2
Jarin
lgtm
5 years, 5 months ago (2015-07-06 07:20:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1225683004/1
5 years, 5 months ago (2015-07-06 07:20:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1225683004/20001
5 years, 5 months ago (2015-07-06 07:45:17 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-06 08:27:07 UTC) #10
commit-bot: I haz the power
5 years, 5 months ago (2015-07-06 08:27:21 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b0a852e8c2ce2add1ba8a26d572aff39af0968a3
Cr-Commit-Position: refs/heads/master@{#29476}

Powered by Google App Engine
This is Rietveld 408576698