Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Issue 1225673006: Revert of mandoline filesystem: Save cookie data to the mojo:filesystem. (Closed)

Created:
5 years, 5 months ago by Fady Samuel
Modified:
5 years, 5 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@sqlite-fs
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of mandoline filesystem: Save cookie data to the mojo:filesystem. (patchset #16 id:300001 of https://codereview.chromium.org/1179413010/) Reason for revert: I'm seeing the following crash when closing the Mandoline window on Linux: [0707/104753:FATAL:sqlite_persistent_cookie_store.cc(1135)] Check failed: false. Could not add a cookie to the DB. #0 0x00000046aef1 __interceptor_backtrace #1 0x7fec4b87954e base::debug::StackTrace::StackTrace() #2 0x7fec4b479a1d logging::LogMessage::~LogMessage() #3 0x7fec53f03c23 net::SQLitePersistentCookieStore::Backend::Commit() #4 0x7fec53f04f38 net::SQLitePersistentCookieStore::Backend::InternalBackgroundClose() #5 0x7fec53f1902b base::internal::RunnableAdapter<>::Run() Reverting this patch resolves the issue. Original issue's description: > mandoline filesystem: Save cookie data to the mojo:filesystem. > > This makes the network service use the sql vfs to proxy writing the > cookies to the filesystem service. This means mojo:network_service does > not directly write its data to the OS filesystem, which will allow us to > sandbox it. > > BUG=493311 > > Committed: https://crrev.com/bbb9e2f6486cccadde4dc2fa077af8f694105eaa > Cr-Commit-Position: refs/heads/master@{#337491} TBR=jam@chromium.org,msw@chromium.org,sky@chromium.org,shess@chromium.org,erg@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=493311 Committed: https://crrev.com/d8eddd344341fee0aca4d5846a0f5d5ef2c2a037 Cr-Commit-Position: refs/heads/master@{#337602}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -389 lines) Patch
M components/filesystem/file_system_impl.h View 2 chunks +3 lines, -18 lines 0 comments Download
M components/filesystem/file_system_impl.cc View 3 chunks +2 lines, -106 lines 0 comments Download
M mandoline/services/core_services/core_services_application_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/runner/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M mojo/runner/child_process_host.cc View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/runner/context.h View 2 chunks +0 lines, -2 lines 0 comments Download
D mojo/runner/scoped_user_data_dir.h View 1 chunk +0 lines, -28 lines 0 comments Download
D mojo/runner/scoped_user_data_dir.cc View 1 chunk +0 lines, -40 lines 0 comments Download
M mojo/runner/switches.h View 1 chunk +0 lines, -2 lines 0 comments Download
M mojo/runner/switches.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M mojo/services/network/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/services/network/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
M mojo/services/network/network_context.h View 3 chunks +2 lines, -7 lines 0 comments Download
M mojo/services/network/network_context.cc View 5 chunks +4 lines, -26 lines 0 comments Download
M mojo/services/network/network_service_delegate.h View 3 chunks +0 lines, -14 lines 0 comments Download
M mojo/services/network/network_service_delegate.cc View 2 chunks +5 lines, -95 lines 0 comments Download
M mojo/tools/mopy/gtest.py View 1 chunk +4 lines, -5 lines 0 comments Download
M sql/mojo/mojo_vfs.cc View 2 chunks +1 line, -17 lines 0 comments Download
M sql/mojo/vfs_unittest.cc View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Fady Samuel
Created Revert of mandoline filesystem: Save cookie data to the mojo:filesystem.
5 years, 5 months ago (2015-07-07 14:49:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1225673006/1
5 years, 5 months ago (2015-07-07 14:50:36 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-07 14:51:49 UTC) #3
commit-bot: I haz the power
5 years, 5 months ago (2015-07-07 14:53:22 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d8eddd344341fee0aca4d5846a0f5d5ef2c2a037
Cr-Commit-Position: refs/heads/master@{#337602}

Powered by Google App Engine
This is Rietveld 408576698