Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(983)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/common.gypi

Issue 12256052: Revert 182241 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/clang/scripts/update.sh » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
===================================================================
--- build/common.gypi (revision 182602)
+++ build/common.gypi (working copy)
@@ -2790,10 +2790,6 @@
# Warns on switches on enums that cover all enum values but
# also contain a default: branch. Chrome is full of that.
'-Wno-covered-switch-default',
-
- # TODO(thakis,hans): Remove once Clang doesn't warn about false
- # positives in our code.
- '-Wno-undefined-internal',
],
'cflags!': [
# Clang doesn't seem to know know this flag.
@@ -3378,10 +3374,6 @@
# Warns on switches on enums that cover all enum values but
# also contain a default: branch. Chrome is full of that.
'-Wno-covered-switch-default',
-
- # TODO(thakis,hans): Remove once Clang doesn't warn about false
- # positives in our code.
- '-Wno-undefined-internal',
],
'OTHER_CPLUSPLUSFLAGS': [
# gnu++11 instead of c++11 so that __ANSI_C__ doesn't get
« no previous file with comments | « no previous file | tools/clang/scripts/update.sh » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698