Second batch of fixing prefs registrations.

chrome/browser/ui/gtk/browser_window_gtk.cc

Index: chrome/browser/ui/gtk/browser_window_gtk.cc
diff --git a/chrome/browser/ui/gtk/browser_window_gtk.cc b/chrome/browser/ui/gtk/browser_window_gtk.cc
index 50f85487e9f3c9f8988c5efa2655ad0e780f9212..66d2be2b31ad67aecafced7354d938c29e6ccf94 100644
--- a/chrome/browser/ui/gtk/browser_window_gtk.cc
+++ b/chrome/browser/ui/gtk/browser_window_gtk.cc
@@ -1486,16 +1486,13 @@ GtkWidget* BrowserWindowGtk::titlebar_widget() const {
 }
 
 // static
-void BrowserWindowGtk::RegisterUserPrefs(PrefService* prefs,
-                                         PrefRegistrySyncable* registry) {
-  // TODO(joi): Remove PrefService parameter.
+void BrowserWindowGtk::RegisterUserPrefs(PrefRegistrySyncable* registry) {
   bool custom_frame_default = false;
   // Avoid checking the window manager if we're not connected to an X server (as
   // is the case in Valgrind tests).
-  if (ui::XDisplayExists() &&
-      !prefs->HasPrefPath(prefs::kUseCustomChromeFrame)) {
+  if (ui::XDisplayExists())
     custom_frame_default = GetCustomFramePrefDefault();
-  }
+
   registry->RegisterBooleanPref(prefs::kUseCustomChromeFrame,

[Jói, 2013/02/18 16:09:27]

Note that this only sets the default value, and does not change the set value if
the pref is already set, so there was no need to check
prefs->HasPrefPath(kUseCustomChromeFrame) in the version before this patch.

                                 custom_frame_default,
                                 PrefRegistrySyncable::UNSYNCABLE_PREF);