Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5453)

Unified Diff: chrome/browser/sync/invalidations/invalidator_storage.h

Issue 12256040: Second batch of fixing prefs registrations. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/invalidations/invalidator_storage.h
diff --git a/chrome/browser/sync/invalidations/invalidator_storage.h b/chrome/browser/sync/invalidations/invalidator_storage.h
index 31cca1298c962f644b97f80f1fc8bfd8c4e6b0b4..ac9f6ad8cda79c3f2deab0c245980f66d9b365b4 100644
--- a/chrome/browser/sync/invalidations/invalidator_storage.h
+++ b/chrome/browser/sync/invalidations/invalidator_storage.h
@@ -33,10 +33,11 @@ namespace browser_sync {
class InvalidatorStorage : public base::SupportsWeakPtr<InvalidatorStorage>,
public syncer::InvalidationStateTracker {
public:
+ static void RegisterUserPrefs(PrefRegistrySyncable* registry);
Mattias Nissler (ping if slow) 2013/02/15 12:23:15 Where do you call this?
Jói 2013/02/18 16:05:42 Fixed, now called in chrome::RegisterUserPrefs in
+
// |pref_service| may be NULL (for unit tests), but in that case no setter
// methods should be called. Does not own |pref_service|.
- explicit InvalidatorStorage(PrefService* pref_service,
- PrefRegistrySyncable* registry);
+ explicit InvalidatorStorage(PrefService* pref_service);
virtual ~InvalidatorStorage();
// Erases invalidation versions and state stored on disk.
@@ -92,7 +93,7 @@ class InvalidatorStorage : public base::SupportsWeakPtr<InvalidatorStorage>,
// Code for migrating from old MaxInvalidationVersions pref, which was a map
// from sync types to max invalidation versions.
- void MigrateMaxInvalidationVersionsPref(PrefRegistrySyncable* registry);
+ void MigrateMaxInvalidationVersionsPref();
static void DeserializeMap(const base::DictionaryValue* max_versions_dict,
syncer::InvalidationStateMap* map);

Powered by Google App Engine
This is Rietveld 408576698