Issue 12256040: Second batch of fixing prefs registrations.

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -61 lines)			Patch
M	chrome/browser/extensions/extension_prefs.cc	View	1 2 3 4 5 6 7 8	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/prefs/browser_prefs.cc	View	1 2 3 4 5 6 7 8	3 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/sync/glue/sync_backend_host_unittest.cc	View	1 2 3 4	1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/browser/sync/invalidations/invalidator_storage.h	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/sync/invalidations/invalidator_storage.cc	View	1 2 3 4 5 6	2 chunks	+18 lines, -19 lines	0 comments	Download
M	chrome/browser/sync/invalidations/invalidator_storage_unittest.cc	View	1 2 3 4 5 6 7	8 chunks	+11 lines, -7 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service.cc	View	1 2 3 4 5 6 7 8 9 10	1 chunk	+1 line, -4 lines	0 comments	Download
M	chrome/browser/ui/gtk/browser_window_gtk.h	View		2 chunks	+1 line, -3 lines	0 comments	Download
M	chrome/browser/ui/gtk/browser_window_gtk.cc	View	1 2 3 4 5 6 7 8 9	1 chunk	+3 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/views/browser_actions_container.h	View	1 2 3 4 5 6 7 8	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/views/browser_actions_container.cc	View	1 2 3 4 5 6 7 8	3 chunks	+0 lines, -15 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Jói

As before, will loop in relevant owners once you've done an initial pass and trybots ...

7 years, 10 months ago (2013-02-14 15:29:26 UTC) #1

Mattias Nissler (ping if slow)

Also good - OK to pull in OWNERS. https://codereview.chromium.org/12256040/diff/1/chrome/browser/sync/invalidations/invalidator_storage.h File chrome/browser/sync/invalidations/invalidator_storage.h (right): https://codereview.chromium.org/12256040/diff/1/chrome/browser/sync/invalidations/invalidator_storage.h#newcode36 chrome/browser/sync/invalidations/invalidator_storage.h:36: static ...

7 years, 10 months ago (2013-02-15 12:23:15 UTC) #2

Jói

Review comments addressed. https://codereview.chromium.org/12256040/diff/1/chrome/browser/sync/invalidations/invalidator_storage.h File chrome/browser/sync/invalidations/invalidator_storage.h (right): https://codereview.chromium.org/12256040/diff/1/chrome/browser/sync/invalidations/invalidator_storage.h#newcode36 chrome/browser/sync/invalidations/invalidator_storage.h:36: static void RegisterUserPrefs(PrefRegistrySyncable* registry); On 2013/02/15 ...

7 years, 10 months ago (2013-02-18 16:05:42 UTC) #3

Jói

+ben, tim for OWNERS rubber stamps. The changes are fairly trivial changes to how preferences ...

7 years, 10 months ago (2013-02-18 16:09:27 UTC) #4

Jói

7 years, 10 months ago (2013-02-21 13:56:36 UTC) #8

Message was sent while issue was closed.

Committed patchset #12 manually as r183799 (presubmit successful).

Expand Messages | Collapse Messages

Issue 12256040: Second batch of fixing prefs registrations. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address review comments and merge LKGR. #

Patch Set 3 : Fix build and checkdeps. #

Patch Set 4 : Fix compile. #

Patch Set 5 : Fix unit test build. #

Patch Set 6 : . #

Patch Set 7 : Fix views build. #

Patch Set 8 : Fix InvalidatorStorageTest. #

Patch Set 9 : Fix views build. #

Patch Set 10 : Merge LKGR #

Patch Set 11 : Merge LKGR #

Patch Set 12 : Merge to head for commit. #

Messages