Separate invalidator and sync client ID (part 1/2)

sync/protocol/sync.proto

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Sync protocol for communication between sync client and server.
 
 // Update proto_value_conversions{.h,.cc,_unittest.cc} if you change
 // any fields in this file.
 
 syntax = "proto2";
@@ skipping 547 matching lines @@
   // server.
   optional ChipBag bag_of_chips = 11;
 
   // Google API key.
   optional string api_key = 12;
 
   // Client's self-reported state.
   // The client should set this on every message sent to the server, though its
   // member fields may often be unset.
   optional ClientStatus client_status = 13;
+
+  // The ID that our invalidation client used to identify itself to the server.
+  // Sending the ID here allows the server to not send notifications of our own
+  // changes to our invalidator.
+  optional string invalidator_client_id = 14;

[Nicolas Zea, 2013/02/20 23:23:15]

should this be part of the ClientToServerMessage or the CommitMessage?

[rlarocque, 2013/02/20 23:53:32]

The server only needs access to it for commit messages, but there's no harm in
sending it up on every request.

IIRC, Raz had a slight preference for including it in all requests, but I forget
why that was.  Perhaps it had something to do with future-compatibility?

 };
 
 message CommitResponse {
   enum ResponseType {
     SUCCESS = 1;
     CONFLICT = 2; // You're out of date; update and check your data
     // TODO(ncarter): What's the difference between RETRY and TRANSIENT_ERROR?
     RETRY = 3; // Someone has a conflicting, non-expired session open
     INVALID_MESSAGE = 4; // What the client sent was invalid, and trying again
                          // won't help.
@@ skipping 178 matching lines @@
     // is absent then the whole client (all datatypes) is throttled.
     repeated int32 error_data_type_ids = 5;
   }
   optional Error error = 13;
 
   // The new per-client state for this client. If set, should be persisted and
   // sent with any subsequent ClientToServerMessages.
   optional ChipBag new_bag_of_chips = 14;
 };