Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 12256031: Add a non-const APIPermissionSet to Extension to be manipulated during initialization. (Closed)

Created:
7 years, 10 months ago by Yoyo Zhou
Modified:
7 years, 10 months ago
Reviewers:
Matt Perry
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org, Devlin, mhx348_motorola.com
Visibility:
Public.

Description

Add a non-const APIPermissionSet to Extension to be manipulated during initialization. This makes it possible for ManifestHandlers to read and modify the initial API permissions. BUG=159265 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182796

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -64 lines) Patch
M chrome/common/extensions/extension.h View 1 8 chunks +18 lines, -18 lines 0 comments Download
M chrome/common/extensions/extension.cc View 1 15 chunks +34 lines, -46 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Yoyo Zhou
7 years, 10 months ago (2013-02-14 00:38:54 UTC) #1
Yoyo Zhou
cc: Devlin, Joe FYI
7 years, 10 months ago (2013-02-14 00:40:47 UTC) #2
Matt Perry
LGTM. Though couldn't you also just pass api_permissions_ to ManifestHandler::Parse?
7 years, 10 months ago (2013-02-14 00:47:00 UTC) #3
Yoyo Zhou
On 2013/02/14 00:47:00, Matt Perry wrote: > LGTM. Though couldn't you also just pass api_permissions_ ...
7 years, 10 months ago (2013-02-14 00:49:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/12256031/10002
7 years, 10 months ago (2013-02-14 01:18:59 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) aura_unittests, base_unittests, browser_tests, cacheinvalidation_unittests, check_deps, chromeos_unittests, ...
7 years, 10 months ago (2013-02-14 01:43:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/12256031/10002
7 years, 10 months ago (2013-02-14 02:36:39 UTC) #7
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=99533
7 years, 10 months ago (2013-02-14 05:38:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/12256031/10002
7 years, 10 months ago (2013-02-14 16:16:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/12256031/10002
7 years, 10 months ago (2013-02-14 22:27:33 UTC) #10
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=11123
7 years, 10 months ago (2013-02-15 12:24:39 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/12256031/10002
7 years, 10 months ago (2013-02-15 19:48:43 UTC) #12
commit-bot: I haz the power
7 years, 10 months ago (2013-02-15 19:50:30 UTC) #13
Message was sent while issue was closed.
Change committed as 182796

Powered by Google App Engine
This is Rietveld 408576698