Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1442)

Unified Diff: tests/stubout_mode/nacl.scons

Issue 12256018: [MIPS] Add remaining parts for building tests for MIPS (Closed) Base URL: http://src.chromium.org/native_client/trunk/src/native_client/
Patch Set: Update per codereview. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/stubout_mode/nacl.scons
diff --git a/tests/stubout_mode/nacl.scons b/tests/stubout_mode/nacl.scons
index dc94213b40c933bdb7415bcbc352b8b04a71cfaa..072c2630e41e459dd3d63a9fea86a4866cb17b80 100644
--- a/tests/stubout_mode/nacl.scons
+++ b/tests/stubout_mode/nacl.scons
@@ -75,18 +75,26 @@ node = env.CommandSelLdrTestNacl(
env.AddNodeToTestSuite(node, test_suites, 'run_without_stubout_2_test')
# With "-s", the executable runs part way but then faults.
+
+if env.Bit('target_mips32'):
+ partly_invalid_exit_status = 'sigtrap'
+else:
+ partly_invalid_exit_status = 'untrusted_sigill'
+
node = env.CommandSelLdrTestNacl(
'partly_invalid_3.out', partly_invalid_nexe,
stdout_golden=env.File('with_stubout.stdout'),
sel_ldr_flags=['-s'],
- exit_status='untrusted_sigill')
+ exit_status=partly_invalid_exit_status)
env.AddNodeToTestSuite(node, test_suites, 'run_stubout_mode_test')
# Using the standalone ncval_stubout tool to rewrite the executable
# offline should be equivalent to using sel_ldr's "-s" option.
+# This tool exists only for x86.
node = env.CommandSelLdrTestNacl(
- 'partly_invalid_stubout.out',
- partly_invalid_stubout_nexe,
- stdout_golden=env.File('with_stubout.stdout'),
- exit_status='untrusted_sigill')
-env.AddNodeToTestSuite(node, test_suites, 'run_offline_stubout_test')
+ 'partly_invalid_stubout.out',
+ partly_invalid_stubout_nexe,
+ stdout_golden=env.File('with_stubout.stdout'),
+ exit_status='untrusted_sigill')
+env.AddNodeToTestSuite(node, test_suites, 'run_offline_stubout_test',
+ is_broken=env.Bit('target_mips32'))

Powered by Google App Engine
This is Rietveld 408576698