Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Unified Diff: tests/data_not_executable/nacl.scons

Issue 12256018: [MIPS] Add remaining parts for building tests for MIPS (Closed) Base URL: http://src.chromium.org/native_client/trunk/src/native_client/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/data_not_executable/nacl.scons
diff --git a/tests/data_not_executable/nacl.scons b/tests/data_not_executable/nacl.scons
index 876d9684f22e30ce168e4851632d44d4c7383832..9fa501f562824e2fe39a1c437e65ac0d5a72960c 100644
--- a/tests/data_not_executable/nacl.scons
+++ b/tests/data_not_executable/nacl.scons
@@ -22,8 +22,9 @@ node = prog_env.CommandSelLdrTestNacl(
prog_env.AddNodeToTestSuite(node, ['small_tests', 'nonpexe_tests'],
'run_execute_data_test',
- # This test hangs on qemu-arm when the
+ # This test hangs on qemu-arm and qemu-mips when the
# fault is caught by NaCl's signal
# handler.
- is_broken=(env.Bit('target_arm') and
+ is_broken=((env.Bit('target_arm') or
+ env.Bit('target_mips32')) and
Mark Seaborn 2013/02/13 22:14:09 Please just remove the env.Bit('target_arm') (and
petarj 2013/03/05 17:50:04 Done.
env.UsingEmulator()))

Powered by Google App Engine
This is Rietveld 408576698