pylib/gyp/msvs_emulation.py - Issue 12256017: Remove default import library inheritance/configuration.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pylib/gyp/msvs_emulation.py

Issue 12256017: Remove default import library inheritance/configuration. (Closed) Base URL: https://chromium.googlesource.com/external/gyp.git@lkgr

Patch Set: Rebase to head in preparation for landing. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pylib/gyp/msvs_emulation.py

diff --git a/pylib/gyp/msvs_emulation.py b/pylib/gyp/msvs_emulation.py

index c8c672db806f1831b579230cc3cee2ed646ab4dd..bc2afca3e0b0298b8003c6614f2e9fd040b934e0 100644

--- a/pylib/gyp/msvs_emulation.py

+++ b/pylib/gyp/msvs_emulation.py

@@ -453,10 +453,6 @@ class MsvsSettings(object):

map={'1': ':NO', '2': ''}, prefix='/LARGEADDRESSAWARE')

# TODO(scottmg): This should sort of be somewhere else (not really a flag).

ld('AdditionalDependencies', prefix='')

- # TODO(scottmg): These too.

- ldflags.extend(('kernel32.lib', 'user32.lib', 'gdi32.lib', 'winspool.lib',

- 'comdlg32.lib', 'advapi32.lib', 'shell32.lib', 'ole32.lib',

- 'oleaut32.lib', 'uuid.lib', 'odbc32.lib', 'DelayImp.lib'))

# If the base address is not specifically controlled, DYNAMICBASE should

# be on by default.

« no previous file with comments | « pylib/gyp/generator/msvs.py ('k') | test/win/gyptest-link-default-libs.py » ('j') | no next file with comments »