Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Unified Diff: pnacl/driver/pnacl-driver.py

Issue 12256013: [MIPS] Fix missing definitions for MIPS arch in build and driver scripts (Closed) Base URL: http://git.chromium.org/native_client/src/native_client.git@master
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pnacl/driver/pnacl-driver.py
diff --git a/pnacl/driver/pnacl-driver.py b/pnacl/driver/pnacl-driver.py
index c56d900ec253656158c59b5febb0b61af967b737..7cc5cf37547053bea705c4259effdfa991372756 100755
--- a/pnacl/driver/pnacl-driver.py
+++ b/pnacl/driver/pnacl-driver.py
@@ -56,6 +56,7 @@ EXTRA_ENV = {
'BIAS_NONE' : '',
'BIAS_ARM' : '-D__arm__ -D__ARM_ARCH_7A__ -D__ARMEL__',
+ 'BIAS_MIPS32' : '-D__MIPS__ -D__mips__ -D__MIPSEL__ -U__MIPSEB__',
Mark Seaborn 2013/02/13 19:17:52 Setting both __MIPSEL__ (little endian) and __MIPS
petarj 2013/02/13 20:45:02 On 2013/02/13 19:17:52, Mark Seaborn wrote: It's
Mark Seaborn 2013/02/13 20:53:17 Oh, I didn't notice that. But still, we shouldn't
petarj 2013/02/14 01:06:52 I have removed it now as I can not recall why we p
'BIAS_X8632' : '-D__i386__ -D__i386 -D__i686 -D__i686__ -D__pentium4__',
'BIAS_X8664' : '-D__amd64__ -D__amd64 -D__x86_64__ -D__x86_64 -D__core2__',
'FRONTEND_TRIPLE' : 'le32-unknown-nacl',

Powered by Google App Engine
This is Rietveld 408576698