Issue 12256006: Limit stack size of sweeper threads.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12256006: Limit stack size of sweeper threads. (Closed)

Created:
7 years, 10 months ago by Hannes Payer (out of office)

Modified:
7 years, 10 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Limit stack size of sweeper threads. BUG= Committed: https://code.google.com/p/v8/source/detail?r=13653

Patch Set 2 : #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	src/sweeper-thread.cc	View	1	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM with a nit. https://chromiumcodereview.appspot.com/12256006/diff/1/src/sweeper-thread.cc File src/sweeper-thread.cc (right): https://chromiumcodereview.appspot.com/12256006/diff/1/src/sweeper-thread.cc#newcode41 src/sweeper-thread.cc:41: : Thread(Thread::Options("SweeperThread", kSweeperThreadStackSize)), While we ...

7 years, 10 months ago (2013-02-13 13:17:54 UTC) #2

Hannes Payer (out of office)

7 years, 10 months ago (2013-02-13 13:19:27 UTC) #3

https://chromiumcodereview.appspot.com/12256006/diff/1/src/sweeper-thread.cc
File src/sweeper-thread.cc (right):

https://chromiumcodereview.appspot.com/12256006/diff/1/src/sweeper-thread.cc#...
src/sweeper-thread.cc:41: : Thread(Thread::Options("SweeperThread",
kSweeperThreadStackSize)),
On 2013/02/13 13:17:54, Michael Starzinger wrote:
> While we are at it, let's also prefix the thread name with "v8:" like for all
> the other service-threads.

Done.

Expand Messages | Collapse Messages

Issue 12256006: Limit stack size of sweeper threads. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages