Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Issue 12256005: Replace seq invocation with 'jot -'. They don't have seq on Mac by default. (Closed)

Created:
7 years, 10 months ago by Alexander Potapenko
Modified:
7 years, 10 months ago
CC:
chromium-reviews, dmikurube+clang_chromium.org, fischman+watch_chromium.org, glider+clang_chromium.org, glotov+watch_chromium.org, ukai+watch_chromium.org, eugenis+clang_chromium.org
Visibility:
Public.

Description

Replace seq invocation with 'jot -'. They don't have seq on Mac by default. Make sure on_asan_mac_host() always returns 1 on non-Darwin systems. BUG=170629, 174873 TBR=thakis Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182201

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M tools/clang/scripts/update.sh View 1 2 2 chunks +4 lines, -1 line 2 comments Download

Messages

Total messages: 7 (0 generated)
Alexander Potapenko
TBR
7 years, 10 months ago (2013-02-13 12:24:17 UTC) #1
hans
https://codereview.chromium.org/12256005/diff/1/tools/clang/scripts/update.sh File tools/clang/scripts/update.sh (right): https://codereview.chromium.org/12256005/diff/1/tools/clang/scripts/update.sh#newcode100 tools/clang/scripts/update.sh:100: for num in $(jot - 600 655) my linux ...
7 years, 10 months ago (2013-02-13 12:25:34 UTC) #2
Alexander Potapenko
https://codereview.chromium.org/12256005/diff/1/tools/clang/scripts/update.sh File tools/clang/scripts/update.sh (right): https://codereview.chromium.org/12256005/diff/1/tools/clang/scripts/update.sh#newcode100 tools/clang/scripts/update.sh:100: for num in $(jot - 600 655) On 2013/02/13 ...
7 years, 10 months ago (2013-02-13 12:30:07 UTC) #3
hans
On 2013/02/13 12:30:07, Alexander Potapenko wrote: > https://codereview.chromium.org/12256005/diff/1/tools/clang/scripts/update.sh > File tools/clang/scripts/update.sh (right): > > https://codereview.chromium.org/12256005/diff/1/tools/clang/scripts/update.sh#newcode100 ...
7 years, 10 months ago (2013-02-13 12:35:55 UTC) #4
Mark Mentovai
https://codereview.chromium.org/12256005/diff/8001/tools/clang/scripts/update.sh File tools/clang/scripts/update.sh (right): https://codereview.chromium.org/12256005/diff/8001/tools/clang/scripts/update.sh#newcode103 tools/clang/scripts/update.sh:103: for num in $(jot - 600 655) You’re using ...
7 years, 10 months ago (2013-02-13 13:37:55 UTC) #5
Nico
https://codereview.chromium.org/12256005/diff/8001/tools/clang/scripts/update.sh File tools/clang/scripts/update.sh (right): https://codereview.chromium.org/12256005/diff/8001/tools/clang/scripts/update.sh#newcode103 tools/clang/scripts/update.sh:103: for num in $(jot - 600 655) On 2013/02/13 ...
7 years, 10 months ago (2013-02-13 15:48:29 UTC) #6
_com_google_glider
7 years, 10 months ago (2013-02-13 19:22:54 UTC) #7
I've learned something today.
On Feb 13, 2013 7:48 PM, <thakis@chromium.org> wrote:

>
> https://codereview.chromium.**org/12256005/diff/8001/tools/**
>
clang/scripts/update.sh<https://codereview.chromium.org/12256005/diff/8001/tools/clang/scripts/update.sh>
> File tools/clang/scripts/update.sh (right):
>
> https://codereview.chromium.**org/12256005/diff/8001/tools/**
>
clang/scripts/update.sh#**newcode103<https://codereview.chromium.org/12256005/diff/8001/tools/clang/scripts/update.sh#newcode103>
> tools/clang/scripts/update.sh:**103: for num in $(jot - 600 655)
> On 2013/02/13 13:37:55, Mark Mentovai wrote:
>
>> You’re using bash. Why not use the built-in form?
>>
>
>     for num in {600..655}
>>
>
> +1
>
>
https://codereview.chromium.**org/12256005/<https://codereview.chromium.org/1...
>

Powered by Google App Engine
This is Rietveld 408576698