Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(887)

Side by Side Diff: net/spdy/spdy_protocol_test.cc

Issue 12256004: Remove SpdySynReplyControlFrame and SpdyGoAwayControlFrame. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « net/spdy/spdy_protocol.h ('k') | net/tools/flip_server/spdy_interface.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/spdy/spdy_protocol.h" 5 #include "net/spdy/spdy_protocol.h"
6 6
7 #include "base/memory/scoped_ptr.h" 7 #include "base/memory/scoped_ptr.h"
8 #include "net/spdy/spdy_bitmasks.h" 8 #include "net/spdy/spdy_bitmasks.h"
9 #include "net/spdy/spdy_framer.h" 9 #include "net/spdy/spdy_framer.h"
10 #include "testing/platform_test.h" 10 #include "testing/platform_test.h"
(...skipping 30 matching lines...) Expand all
41 // Test our protocol constants 41 // Test our protocol constants
42 TEST_P(SpdyProtocolTest, ProtocolConstants) { 42 TEST_P(SpdyProtocolTest, ProtocolConstants) {
43 EXPECT_EQ(8u, SpdyFrame::kHeaderSize); 43 EXPECT_EQ(8u, SpdyFrame::kHeaderSize);
44 EXPECT_EQ(8u, SpdyDataFrame::size()); 44 EXPECT_EQ(8u, SpdyDataFrame::size());
45 EXPECT_EQ(8u, SpdyControlFrame::kHeaderSize); 45 EXPECT_EQ(8u, SpdyControlFrame::kHeaderSize);
46 EXPECT_EQ(18u, SpdySynStreamControlFrame::size()); 46 EXPECT_EQ(18u, SpdySynStreamControlFrame::size());
47 EXPECT_EQ(12u, SpdySynReplyControlFrame::size()); 47 EXPECT_EQ(12u, SpdySynReplyControlFrame::size());
48 EXPECT_EQ(16u, SpdyRstStreamControlFrame::size()); 48 EXPECT_EQ(16u, SpdyRstStreamControlFrame::size());
49 EXPECT_EQ(12u, SpdySettingsControlFrame::size()); 49 EXPECT_EQ(12u, SpdySettingsControlFrame::size());
50 EXPECT_EQ(12u, SpdyPingControlFrame::size()); 50 EXPECT_EQ(12u, SpdyPingControlFrame::size());
51 EXPECT_EQ(16u, SpdyGoAwayControlFrame::size());
52 EXPECT_EQ(12u, SpdyHeadersControlFrame::size()); 51 EXPECT_EQ(12u, SpdyHeadersControlFrame::size());
53 EXPECT_EQ(16u, SpdyWindowUpdateControlFrame::size()); 52 EXPECT_EQ(16u, SpdyWindowUpdateControlFrame::size());
54 EXPECT_EQ(4u, sizeof(FlagsAndLength)); 53 EXPECT_EQ(4u, sizeof(FlagsAndLength));
55 EXPECT_EQ(1, SYN_STREAM); 54 EXPECT_EQ(1, SYN_STREAM);
56 EXPECT_EQ(2, SYN_REPLY); 55 EXPECT_EQ(2, SYN_REPLY);
57 EXPECT_EQ(3, RST_STREAM); 56 EXPECT_EQ(3, RST_STREAM);
58 EXPECT_EQ(4, SETTINGS); 57 EXPECT_EQ(4, SETTINGS);
59 EXPECT_EQ(5, NOOP); 58 EXPECT_EQ(5, NOOP);
60 EXPECT_EQ(6, PING); 59 EXPECT_EQ(6, PING);
61 EXPECT_EQ(7, GOAWAY); 60 EXPECT_EQ(7, GOAWAY);
(...skipping 16 matching lines...) Expand all
78 EXPECT_EQ(10u, frame.flags()); 77 EXPECT_EQ(10u, frame.flags());
79 EXPECT_FALSE(frame.is_control_frame()); 78 EXPECT_FALSE(frame.is_control_frame());
80 } 79 }
81 80
82 TEST_P(SpdyProtocolTest, DataFrameStructs) { 81 TEST_P(SpdyProtocolTest, DataFrameStructs) {
83 SpdyDataFrame data_frame; 82 SpdyDataFrame data_frame;
84 data_frame.set_stream_id(12345); 83 data_frame.set_stream_id(12345);
85 EXPECT_EQ(12345u, data_frame.stream_id()); 84 EXPECT_EQ(12345u, data_frame.stream_id());
86 } 85 }
87 86
88 TEST_P(SpdyProtocolTest, ControlFrameStructs) {
89 SpdyFramer framer(spdy_version_);
90 SpdyHeaderBlock headers;
91
92 const uint8 credential_slot = IsSpdy2() ? 0 : 5;
93
94 scoped_ptr<SpdySynStreamControlFrame> syn_frame(framer.CreateSynStream(
95 123, 456, 2, credential_slot, CONTROL_FLAG_FIN, false, &headers));
96 EXPECT_EQ(framer.protocol_version(), syn_frame->version());
97 EXPECT_TRUE(syn_frame->is_control_frame());
98 EXPECT_EQ(SYN_STREAM, syn_frame->type());
99 EXPECT_EQ(123u, syn_frame->stream_id());
100 EXPECT_EQ(456u, syn_frame->associated_stream_id());
101 EXPECT_EQ(2u, syn_frame->priority());
102 EXPECT_EQ(credential_slot, syn_frame->credential_slot());
103 EXPECT_EQ(IsSpdy2() ? 2 : 4, syn_frame->header_block_len());
104 EXPECT_EQ(1u, syn_frame->flags());
105 syn_frame->set_associated_stream_id(999u);
106 EXPECT_EQ(123u, syn_frame->stream_id());
107 EXPECT_EQ(999u, syn_frame->associated_stream_id());
108
109 scoped_ptr<SpdySynReplyControlFrame> syn_reply(
110 framer.CreateSynReply(123, CONTROL_FLAG_NONE, false, &headers));
111 EXPECT_EQ(framer.protocol_version(), syn_reply->version());
112 EXPECT_TRUE(syn_reply->is_control_frame());
113 EXPECT_EQ(SYN_REPLY, syn_reply->type());
114 EXPECT_EQ(123u, syn_reply->stream_id());
115 EXPECT_EQ(IsSpdy2() ? 2 : 4, syn_reply->header_block_len());
116 EXPECT_EQ(0, syn_reply->flags());
117
118 scoped_ptr<SpdyRstStreamControlFrame> rst_frame(
119 framer.CreateRstStream(123, RST_STREAM_PROTOCOL_ERROR));
120 EXPECT_EQ(framer.protocol_version(), rst_frame->version());
121 EXPECT_TRUE(rst_frame->is_control_frame());
122 EXPECT_EQ(RST_STREAM, rst_frame->type());
123 EXPECT_EQ(123u, rst_frame->stream_id());
124 EXPECT_EQ(RST_STREAM_PROTOCOL_ERROR, rst_frame->status());
125 rst_frame->set_status(RST_STREAM_INVALID_STREAM);
126 EXPECT_EQ(RST_STREAM_INVALID_STREAM, rst_frame->status());
127 EXPECT_EQ(0, rst_frame->flags());
128
129 const uint32 kUniqueId = 1234567u;
130 const uint32 kUniqueId2 = 31415926u;
131 scoped_ptr<SpdyPingControlFrame> ping_frame(
132 framer.CreatePingFrame(kUniqueId));
133 EXPECT_EQ(framer.protocol_version(), ping_frame->version());
134 EXPECT_TRUE(ping_frame->is_control_frame());
135 EXPECT_EQ(PING, ping_frame->type());
136 EXPECT_EQ(kUniqueId, ping_frame->unique_id());
137 ping_frame->set_unique_id(kUniqueId2);
138 EXPECT_EQ(kUniqueId2, ping_frame->unique_id());
139
140 scoped_ptr<SpdyGoAwayControlFrame> goaway_frame(
141 framer.CreateGoAway(123, GOAWAY_INTERNAL_ERROR));
142 EXPECT_EQ(framer.protocol_version(), goaway_frame->version());
143 EXPECT_TRUE(goaway_frame->is_control_frame());
144 EXPECT_EQ(GOAWAY, goaway_frame->type());
145 EXPECT_EQ(123u, goaway_frame->last_accepted_stream_id());
146 if (!IsSpdy2()) {
147 EXPECT_EQ(GOAWAY_INTERNAL_ERROR, goaway_frame->status());
148 }
149
150 scoped_ptr<SpdyHeadersControlFrame> headers_frame(
151 framer.CreateHeaders(123, CONTROL_FLAG_NONE, false, &headers));
152 EXPECT_EQ(framer.protocol_version(), headers_frame->version());
153 EXPECT_TRUE(headers_frame->is_control_frame());
154 EXPECT_EQ(HEADERS, headers_frame->type());
155 EXPECT_EQ(123u, headers_frame->stream_id());
156 EXPECT_EQ(IsSpdy2() ? 2 : 4, headers_frame->header_block_len());
157 EXPECT_EQ(0, headers_frame->flags());
158
159 scoped_ptr<SpdyWindowUpdateControlFrame> window_update_frame(
160 framer.CreateWindowUpdate(123, 456));
161 EXPECT_EQ(framer.protocol_version(), window_update_frame->version());
162 EXPECT_TRUE(window_update_frame->is_control_frame());
163 EXPECT_EQ(WINDOW_UPDATE, window_update_frame->type());
164 EXPECT_EQ(123u, window_update_frame->stream_id());
165 EXPECT_EQ(456u, window_update_frame->delta_window_size());
166 }
167
168 TEST_P(SpdyProtocolTest, TestDataFrame) { 87 TEST_P(SpdyProtocolTest, TestDataFrame) {
169 SpdyDataFrame frame; 88 SpdyDataFrame frame;
170 89
171 // Set the stream ID to various values. 90 // Set the stream ID to various values.
172 frame.set_stream_id(0); 91 frame.set_stream_id(0);
173 EXPECT_EQ(0u, frame.stream_id()); 92 EXPECT_EQ(0u, frame.stream_id());
174 EXPECT_FALSE(frame.is_control_frame()); 93 EXPECT_FALSE(frame.is_control_frame());
175 frame.set_stream_id(~0 & kStreamIdMask); 94 frame.set_stream_id(~0 & kStreamIdMask);
176 EXPECT_EQ(~0 & kStreamIdMask, frame.stream_id()); 95 EXPECT_EQ(~0 & kStreamIdMask, frame.stream_id());
177 EXPECT_FALSE(frame.is_control_frame()); 96 EXPECT_FALSE(frame.is_control_frame());
(...skipping 203 matching lines...) Expand 10 before | Expand all | Expand 10 after
381 300
382 rst_frame->set_status(static_cast<SpdyRstStreamStatus>( 301 rst_frame->set_status(static_cast<SpdyRstStreamStatus>(
383 RST_STREAM_INVALID - 1)); 302 RST_STREAM_INVALID - 1));
384 EXPECT_EQ(RST_STREAM_INVALID, rst_frame->status()); 303 EXPECT_EQ(RST_STREAM_INVALID, rst_frame->status());
385 304
386 rst_frame->set_status(RST_STREAM_NUM_STATUS_CODES); 305 rst_frame->set_status(RST_STREAM_NUM_STATUS_CODES);
387 EXPECT_EQ(RST_STREAM_INVALID, rst_frame->status()); 306 EXPECT_EQ(RST_STREAM_INVALID, rst_frame->status());
388 } 307 }
389 308
390 } // namespace net 309 } // namespace net
OLDNEW
« no previous file with comments | « net/spdy/spdy_protocol.h ('k') | net/tools/flip_server/spdy_interface.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698