Revert "Roll Clang r170392:r174491."

Revert "Roll Clang r170392:r174491."

It turns out that r181918, which pinned the Clang revision on Mac ASan
bots worked a little too well, pinning the version on *all* Mac bots.

This reverts the Clang roll. We will then fix update.sh to get the Mac
ASan pinning correct, and then re-land the roll.

BUG=174873, 170629
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182173

[Alexander Potapenko, 2013-02-13 09:26:46]

LGTM

[Nico, 2013-02-13 15:49:17]

On Wed, Feb 13, 2013 at 1:26 AM,  <hans@chromium.org> wrote:
> Reviewers: Alexander Potapenko, Nico,
>
> Description:
> Revert "Roll Clang r170392:r174491."
>
> It turns out that r181918, which pinned the Clang revision on Mac ASan
> bots worked a little too well, pinning the version on *all* Mac bots.

*all* bots. Linux, too.

>
> This reverts the Clang roll. We will then fix update.sh to get the Mac
> ASan pinning correct, and then re-land the roll.
>
> BUG=174873, 170629
>
>
> Please review this at https://codereview.chromium.org/12256002/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>   M build/common.gypi
>   M tools/clang/scripts/update.sh
>
>
> Index: build/common.gypi
> diff --git a/build/common.gypi b/build/common.gypi
> index
>
5d600b0dba1802959c7f03dec810e7d8fcb0cddb..d42bbee97c916a5bf22aaa04f7ca15e21236f934
> 100644
> --- a/build/common.gypi
> +++ b/build/common.gypi
> @@ -2790,10 +2790,6 @@
>                # Warns on switches on enums that cover all enum values but
>                # also contain a default: branch. Chrome is full of that.
>                '-Wno-covered-switch-default',
> -
> -              # TODO(thakis,hans): Remove once Clang doesn't warn about
> false
> -              # positives in our code.
> -              '-Wno-undefined-internal',
>              ],
>              'cflags!': [
>                # Clang doesn't seem to know know this flag.
> @@ -3378,10 +3374,6 @@
>                  # Warns on switches on enums that cover all enum values but
>                  # also contain a default: branch. Chrome is full of that.
>                  '-Wno-covered-switch-default',
> -
> -                # TODO(thakis,hans): Remove once Clang doesn't warn about
> false
> -                # positives in our code.
> -                '-Wno-undefined-internal',
>                ],
>                'OTHER_CPLUSPLUSFLAGS': [
>                  # gnu++11 instead of c++11 so that __ANSI_C__ doesn't get
> Index: tools/clang/scripts/update.sh
> diff --git a/tools/clang/scripts/update.sh b/tools/clang/scripts/update.sh
> index
>
ce4c2059f84d3bfcc8d958a0f09249aa7eacee94..04fcd2feba18f98fb8fa8472781e9582b167554a
> 100755
> --- a/tools/clang/scripts/update.sh
> +++ b/tools/clang/scripts/update.sh
> @@ -8,7 +8,7 @@
>  # Do NOT CHANGE this if you don't know what you're doing -- see
>  # https://code.google.com/p/chromium/wiki/UpdatingClang
>  # Reverting problematic clang rolls is safe, though.
> -CLANG_REVISION=174491
> +CLANG_REVISION=170392
>  # ASan Mac builders are pinned to this revision, see
> http://crbug.com/170629.
>  CLANG_ASAN_MAC_REVISION=170392
>
>
>

[hans, 2013-02-13 15:50:47]

On 2013/02/13 15:49:17, Nico wrote:
> > It turns out that r181918, which pinned the Clang revision on Mac ASan
> > bots worked a little too well, pinning the version on *all* Mac bots.
> 
> *all* bots. Linux, too.

Sorry, yes I realized that afterwards.