Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Issue 12256002: Revert "Roll Clang r170392:r174491." (Closed)

Created:
7 years, 10 months ago by hans
Modified:
7 years, 10 months ago
CC:
chromium-reviews, fischman+watch_chromium.org, dmikurube+clang_chromium.org, glotov+watch_chromium.org, ukai+watch_chromium.org
Visibility:
Public.

Description

Revert "Roll Clang r170392:r174491." It turns out that r181918, which pinned the Clang revision on Mac ASan bots worked a little too well, pinning the version on *all* Mac bots. This reverts the Clang roll. We will then fix update.sh to get the Mac ASan pinning correct, and then re-land the roll. BUG=174873, 170629 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182173

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -9 lines) Patch
M build/common.gypi View 2 chunks +0 lines, -8 lines 0 comments Download
M tools/clang/scripts/update.sh View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
hans
7 years, 10 months ago (2013-02-13 09:26:01 UTC) #1
Alexander Potapenko
LGTM
7 years, 10 months ago (2013-02-13 09:26:46 UTC) #2
Nico
On Wed, Feb 13, 2013 at 1:26 AM, <hans@chromium.org> wrote: > Reviewers: Alexander Potapenko, Nico, ...
7 years, 10 months ago (2013-02-13 15:49:17 UTC) #3
hans
7 years, 10 months ago (2013-02-13 15:50:47 UTC) #4
Message was sent while issue was closed.
On 2013/02/13 15:49:17, Nico wrote:
> > It turns out that r181918, which pinned the Clang revision on Mac ASan
> > bots worked a little too well, pinning the version on *all* Mac bots.
> 
> *all* bots. Linux, too.

Sorry, yes I realized that afterwards.

Powered by Google App Engine
This is Rietveld 408576698