Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Unified Diff: src/deoptimizer.cc

Issue 1225573002: Record code slots that may point to evacuation candidate objects after deoptimizing them. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/heap/mark-compact.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/deoptimizer.cc
diff --git a/src/deoptimizer.cc b/src/deoptimizer.cc
index 3ab10fcac905871da62fafd9cf9f658e1e7e7d48..080ac2ef30cb2472ff7ef7721b17c554571271bf 100644
--- a/src/deoptimizer.cc
+++ b/src/deoptimizer.cc
@@ -417,6 +417,11 @@ void Deoptimizer::DeoptimizeMarkedCodeForContext(Context* context) {
// Ignore all slots that might have been recorded on the deoptimized code
// object.
isolate->heap()->mark_compact_collector()->RemoveObjectSlots(codes[i]);
+
+ // After removing all recorded slots of the code object, we add the slots
+ // again that point to objects on evacuation candidates.
Michael Starzinger 2015/07/03 10:46:09 nit: Let's add to the comment that this is only ab
Hannes Payer (out of office) 2015/07/03 10:55:53 Done.
+ isolate->heap()->mark_compact_collector()->RecordDeoptimizedCodeSlots(
+ codes[i]);
}
}
« no previous file with comments | « no previous file | src/heap/mark-compact.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698