Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 1225513002: Revert of Reland: Optimizes IndexedDB's DeleteDatabase when no db exists (Closed)

Created:
5 years, 5 months ago by vkuzkokov
Modified:
5 years, 5 months ago
Reviewers:
jsbell, cmumford
CC:
chromium-reviews, darin-cc_chromium.org, dgrogan, jsbell+idb_chromium.org, jam, cmumford
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Reland: Optimizes IndexedDB's DeleteDatabase when no db exists (patchset #1 id:1 of https://codereview.chromium.org/1216573008/) Reason for revert: Some bots still flaky. See crbug.com/506467 Original issue's description: > Reland: Optimizes IndexedDB's DeleteDatabase when no db exists > > When deleting the non existing database in a origin with no existing > backing store, then in DeleteDatabse(), early exiting before > OpenBackingStore, so that it wont results in multiple transaction as > earlier. > > Original patch by: payal.pandey > > This was reverted (see crrev.com/1071553002) when it appeared to make > a test flaky, but the test continues to flake (now tracked as > crbug.com/505609) so let's try relanding. > > BUG=460236 > > Committed: https://crrev.com/4cbc8f1b383fb8145056295176912d53030a98b0 > Cr-Commit-Position: refs/heads/master@{#336796} TBR=cmumford@chromium.org,jsbell@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=460236 Committed: https://crrev.com/4e132285cadc8875bd8bf5d0078f325562fdd620 Cr-Commit-Position: refs/heads/master@{#337228}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -25 lines) Patch
M content/browser/indexed_db/indexed_db_browsertest.cc View 1 chunk +13 lines, -5 lines 0 comments Download
M content/browser/indexed_db/indexed_db_factory_impl.cc View 1 chunk +0 lines, -20 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
vkuzkokov
Created Revert of Reland: Optimizes IndexedDB's DeleteDatabase when no db exists
5 years, 5 months ago (2015-07-02 16:18:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1225513002/1
5 years, 5 months ago (2015-07-02 16:18:23 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-02 16:19:17 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4e132285cadc8875bd8bf5d0078f325562fdd620 Cr-Commit-Position: refs/heads/master@{#337228}
5 years, 5 months ago (2015-07-02 16:20:15 UTC) #4
vkuzkokov
5 years, 5 months ago (2015-07-02 16:51:59 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1224533004/ by vkuzkokov@chromium.org.

The reason for reverting is: Test is still flaky..

Powered by Google App Engine
This is Rietveld 408576698