Issue 12255052: [Telemetry] Fix perf bots after http://crrev.com/183009.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12255052: [Telemetry] Fix perf bots after http://crrev.com/183009. (Closed)

Created:
7 years, 10 months ago by dtu

Modified:
7 years, 10 months ago

Reviewers:
nduca

CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Telemetry] Fix perf bots after http://crrev.com/183009. There were some issues with the patch specific to Android and Windows, which I foolishly did not test. 1. Didn't update new path to build/android in adb_commands.py 2. The move exposed a preexisting bug in discover.py where it doesn't handle Windows paths correctly. TBR=nduca@chromium.org BUG=None. TEST=./run_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183085

Patch Set 1 #

Patch Set 2 : Ugh, a couple of files do this '../..' thing. Use os.path.join instead. #

Patch Set 3 : Fix new test, testComponentExtension. #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -8 lines)			Patch
M	tools/telemetry/telemetry/core/chrome/adb_commands.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/telemetry/telemetry/core/chrome/android_platform.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/telemetry/telemetry/core/chrome/png_bitmap.py	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	tools/telemetry/telemetry/core/chrome/websocket.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/telemetry/telemetry/core/extension_unittest.py	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/telemetry/telemetry/core/wpr_server.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/telemetry/telemetry/page/perf_tests_helper.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/telemetry/telemetry/test/discover.py	View		1 chunk	+1 line, -1 line	0 comments	Download