content/browser/renderer_host/media/video_capture_controller.cc - Issue 12255032: Implement "hole" video frame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/media/video_capture_controller.cc

Issue 12255032: Implement "hole" video frame. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added contact address Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/media/video_capture_controller.cc

diff --git a/content/browser/renderer_host/media/video_capture_controller.cc b/content/browser/renderer_host/media/video_capture_controller.cc

index b503293ea2d197426240e9b51b89b7fe591694ab..d159876b30a6d27e9f93b7b227f6e7e37891e5e7 100644

--- a/content/browser/renderer_host/media/video_capture_controller.cc

+++ b/content/browser/renderer_host/media/video_capture_controller.cc

@@ -421,6 +421,12 @@ void VideoCaptureController::OnIncomingCapturedVideoFrame(

// Do color conversion from the camera format to I420.

switch (frame->format()) {

+#if defined(GOOGLE_TV)

+ case media::VideoFrame::HOLE: {

+ NOTREACHED();

scherkus (not reviewing) 2013/02/27 06:54:20 do you need to duplicate the { NOTREACHED(); break

wonsik2 2013/02/27 10:19:29 Done. Added a short comment for a little safeguard

+ break;

+ }

+#endif

case media::VideoFrame::INVALID:

case media::VideoFrame::YV16:

case media::VideoFrame::EMPTY: