Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issue 12255024: Re-enable photo importer in Files.app. (Closed)

Created:
7 years, 10 months ago by mtomasz
Modified:
7 years, 10 months ago
Reviewers:
yoshiki, hashimoto
CC:
chromium-reviews, nkostylev+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Re-enable photo importer in Files.app. It has been disabled because of bugs. TEST=Enter usb drive, right click on the usb drive item in the left nav in Files.app, choose Import media. BUG=176203 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182422

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M chrome/browser/chromeos/extensions/file_browser_event_router.cc View 1 chunk +1 line, -3 lines 3 comments Download
M chrome/browser/resources/file_manager/main.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
mtomasz
@yoshiki: PTAL.
7 years, 10 months ago (2013-02-14 05:08:44 UTC) #1
yoshiki
lgtm
7 years, 10 months ago (2013-02-14 06:18:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/12255024/1
7 years, 10 months ago (2013-02-14 07:26:12 UTC) #3
commit-bot: I haz the power
Presubmit check for 12255024-1 failed and returned exit status 1. INFO:root:Found 2 file(s). Running presubmit ...
7 years, 10 months ago (2013-02-14 07:26:15 UTC) #4
mtomasz
On 2013/02/14 07:26:15, I haz the power (commit-bot) wrote: > Presubmit check for 12255024-1 failed ...
7 years, 10 months ago (2013-02-14 08:23:36 UTC) #5
hashimoto
file_browser_event_router.cc lgtm https://codereview.chromium.org/12255024/diff/1/chrome/browser/chromeos/extensions/file_browser_event_router.cc File chrome/browser/chromeos/extensions/file_browser_event_router.cc (right): https://codereview.chromium.org/12255024/diff/1/chrome/browser/chromeos/extensions/file_browser_event_router.cc#newcode676 chrome/browser/chromeos/extensions/file_browser_event_router.cc:676: file_manager_util::OpenActionChoiceDialog(FilePath(mount_path)); nit: It seems no one uses ...
7 years, 10 months ago (2013-02-14 08:30:18 UTC) #6
mtomasz
https://codereview.chromium.org/12255024/diff/1/chrome/browser/chromeos/extensions/file_browser_event_router.cc File chrome/browser/chromeos/extensions/file_browser_event_router.cc (right): https://codereview.chromium.org/12255024/diff/1/chrome/browser/chromeos/extensions/file_browser_event_router.cc#newcode676 chrome/browser/chromeos/extensions/file_browser_event_router.cc:676: file_manager_util::OpenActionChoiceDialog(FilePath(mount_path)); On 2013/02/14 08:30:18, hashimoto wrote: > nit: It ...
7 years, 10 months ago (2013-02-14 08:43:39 UTC) #7
hashimoto
7 years, 10 months ago (2013-02-14 08:46:37 UTC) #8
Message was sent while issue was closed.
https://codereview.chromium.org/12255024/diff/1/chrome/browser/chromeos/exten...
File chrome/browser/chromeos/extensions/file_browser_event_router.cc (right):

https://codereview.chromium.org/12255024/diff/1/chrome/browser/chromeos/exten...
chrome/browser/chromeos/extensions/file_browser_event_router.cc:676:
file_manager_util::OpenActionChoiceDialog(FilePath(mount_path));
On 2013/02/14 08:43:39, mtomasz wrote:
> On 2013/02/14 08:30:18, hashimoto wrote:
> > nit: It seems no one uses ViewRemovableDrive after this change, can we
remove
> > it?
> 
> I'm going to use it in m27. The loader will not be launched for any removable
> drive other than sd cards.

OK, sgtm.

Powered by Google App Engine
This is Rietveld 408576698