Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Unified Diff: webkit/fileapi/media/mtp_device_async_delegate.h

Issue 12255023: [Media Galleries] Switch Mac MTP delegate to async interface. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Handle multiple async calls Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/fileapi/media/mtp_device_async_delegate.h
diff --git a/webkit/fileapi/media/mtp_device_async_delegate.h b/webkit/fileapi/media/mtp_device_async_delegate.h
index 4140c379b4e5dbeff62ec2966a0e0eb260469e0b..50fa151a4e3390cc6a139ae30933465c95b36778 100644
--- a/webkit/fileapi/media/mtp_device_async_delegate.h
+++ b/webkit/fileapi/media/mtp_device_async_delegate.h
@@ -22,6 +22,8 @@ namespace fileapi {
// ScopedMTPDeviceMapEntry class manages the lifetime of the delegate via
// MTPDeviceMapService class. Member functions and callbacks runs on the IO
// thread.
+// Note: caller must ensure that the deleting call is not made while there are
Lei Zhang 2013/03/18 09:25:55 I don't think the caller to CancelPendingTasksAndD
Greg Billock 2013/03/20 23:43:55 Uggh. I wasn't sure about this. OK, I'll switch it
+// outstanding async calls to the delegate.
class MTPDeviceAsyncDelegate {
public:
// A callback to be called when GetFileInfo method call succeeds.

Powered by Google App Engine
This is Rietveld 408576698