Issue 12255017: Revert 182279 due to failure in CloudPolicyTest.FetchPolicyWithRotatedKey on ChromeOS Asan bots.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12255017: Revert 182279 due to failure in CloudPolicyTest.FetchPolicyWithRotatedKey on ChromeOS Asan bots. (Closed)

Created:
7 years, 10 months ago by Randy Smith (Not in Mondays)

Modified:
7 years, 10 months ago

Reviewers:
Joao da Silva

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 182279 due to failure in CloudPolicyTest.FetchPolicyWithRotatedKey on ChromeOS Asan bots. > Verify the signature on user cloud policy downloads. > > The signature on the user cloud policy blob is already verified by the session > manager on ChromeOS, but should also be verified by Chrome before storing new > policy, and after loading policy from the cache. > > BUG=174015 > > > Review URL: https://chromiumcodereview.appspot.com/12183017 TBR=joaodasilva@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182302

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+181 lines, -678 lines)			Patch
M	chrome/browser/policy/browser_policy_connector.cc	View	2 chunks	+1 line, -4 lines	0 comments	Download
M	chrome/browser/policy/cloud_policy_browsertest.cc	View	9 chunks	+24 lines, -171 lines	0 comments	Download
M	chrome/browser/policy/user_cloud_policy_store_chromeos.h	View	6 chunks	+12 lines, -45 lines	0 comments	Download
M	chrome/browser/policy/user_cloud_policy_store_chromeos.cc	View	10 chunks	+75 lines, -185 lines	0 comments	Download
M	chrome/browser/policy/user_cloud_policy_store_chromeos_unittest.cc	View	14 chunks	+55 lines, -248 lines	0 comments	Download
M	chrome/common/chrome_paths.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/common/chrome_paths.cc	View	2 chunks	+0 lines, -8 lines	0 comments	Download
M	net/tools/testserver/device_management.py	View	5 chunks	+14 lines, -15 lines	0 comments	Download

Total messages: 1 (0 generated)