Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issue 1225493002: Move slow classes above fast to directly call ReconfigureImpl, remove friends, make things public (Closed)

Created:
5 years, 5 months ago by Toon Verwaest
Modified:
5 years, 5 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Move slow classes above fast to directly call ReconfigureImpl, remove friends, make things public BUG=v8:4137 LOG=n Committed: https://crrev.com/9d0cd81da9fdd736094c733f2ad8033103a264e2 Cr-Commit-Position: refs/heads/master@{#29455}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : Just make everything public within elements.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+316 lines, -371 lines) Patch
M src/elements.cc View 1 2 13 chunks +316 lines, -371 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
Toon Verwaest
ptal
5 years, 5 months ago (2015-07-02 14:10:16 UTC) #2
Igor Sheludko
lgtm with a nit: https://codereview.chromium.org/1225493002/diff/1/src/elements.cc File src/elements.cc (right): https://codereview.chromium.org/1225493002/diff/1/src/elements.cc#newcode1527 src/elements.cc:1527: friend class ElementsAccessorBase<SloppyArgumentsElementsAccessorSubclass, Remove this.
5 years, 5 months ago (2015-07-02 14:15:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1225493002/1
5 years, 5 months ago (2015-07-02 16:05:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1225493002/20001
5 years, 5 months ago (2015-07-02 16:08:14 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_android_arm_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/5579)
5 years, 5 months ago (2015-07-02 16:18:57 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1225493002/40001
5 years, 5 months ago (2015-07-02 16:19:46 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 5 months ago (2015-07-02 16:44:21 UTC) #15
commit-bot: I haz the power
5 years, 5 months ago (2015-07-02 16:44:44 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9d0cd81da9fdd736094c733f2ad8033103a264e2
Cr-Commit-Position: refs/heads/master@{#29455}

Powered by Google App Engine
This is Rietveld 408576698