Issue 122543002: Ensure WeakPtrFactories are at the end of their owning classes and refer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 122543002: Ensure WeakPtrFactories are at the end of their owning classes and refer (Closed)

Created:
6 years, 11 months ago by Peter Kasting

Modified:
6 years, 11 months ago

Reviewers:
dmichael (off chromium), jam, Randy Smith (Not in Mondays)

CC:
chromium-reviews, asanka, benjhayden+dwatch_chromium.org, benquan, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Ensure WeakPtrFactories are at the end of their owning classes and refer directly to their owning class types. Also does a little bit of other non-functional cleanup, mostly eliminating unnecessary get() calls and fixing violations of the "don't handle DCHECK failure" style rule. BUG=303818 TEST=none R=dmichael@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244618

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+46 lines, -57 lines)			Patch
M	chrome/browser/download/download_request_infobar_delegate_unittest.cc	View	4 chunks	+16 lines, -11 lines	0 comments	Download
M	chrome/browser/google/google_url_tracker.h	View	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/google/google_url_tracker.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/intranet_redirect_detector.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/intranet_redirect_detector.cc	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	components/webdata/common/web_database_service.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	components/webdata/common/web_database_service.cc	View	7 chunks	+18 lines, -34 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Peter Kasting

OWNERS TBR=rdsmith for c/b/downloads/ and jam for c/b/

6 years, 11 months ago (2014-01-14 00:20:07 UTC) #3

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages