Issue 12254051: Make content_shell build on Win64

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12254051: Make content_shell build on Win64 (Closed)

Created:
7 years, 10 months ago by jschuh

Modified:
7 years, 10 months ago

Reviewers:
jam

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Make content_shell build on Win64 A c4267 build suppression and some simple compile fixes for the wrong argument types. BUG=166496 BUG=167187 TBR=jam@chromium.org R=jam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182785

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -4 lines)			Patch
	M	content/content_shell.gypi	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	content/shell/shell_javascript_dialog_win.cc	View		4 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jschuh@chromium.org/12254051/1

7 years, 10 months ago (2013-02-15 15:04:50 UTC) #1

jam

lgtm i prefer that changes like this aren't TBR'd. TBR should be for fixing tree ...

7 years, 10 months ago (2013-02-15 16:04:07 UTC) #2

jschuh

7 years, 10 months ago (2013-02-15 16:21:35 UTC) #3

On 2013/02/15 16:04:07, jam wrote:
> lgtm
> 
> i prefer that changes like this aren't TBR'd. TBR should be for fixing tree
> breakage, reverting changes, moving a file etc, but not for normal changes

Ah, sorry. I've been TBRing the warning suppressions in the gyp files, but
you're right that I shouldn't TBR something like this that actually changes the
code (even so superficially).

Expand Messages | Collapse Messages