Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Side by Side Diff: src/code-stubs.h

Issue 12254036: Minor cleanup of CompareIC state (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Actually address all comments Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | src/code-stubs.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 712 matching lines...) Expand 10 before | Expand all | Expand 10 after
723 // Platform-independent implementation. 723 // Platform-independent implementation.
724 void Generate(MacroAssembler* masm); 724 void Generate(MacroAssembler* masm);
725 void GenerateCallRuntime(MacroAssembler* masm); 725 void GenerateCallRuntime(MacroAssembler* masm);
726 726
727 // Platform-independent signature, platform-specific implementation. 727 // Platform-independent signature, platform-specific implementation.
728 void Initialize(); 728 void Initialize();
729 void GenerateAddStrings(MacroAssembler* masm); 729 void GenerateAddStrings(MacroAssembler* masm);
730 void GenerateBothStringStub(MacroAssembler* masm); 730 void GenerateBothStringStub(MacroAssembler* masm);
731 void GenerateGeneric(MacroAssembler* masm); 731 void GenerateGeneric(MacroAssembler* masm);
732 void GenerateGenericStub(MacroAssembler* masm); 732 void GenerateGenericStub(MacroAssembler* masm);
733 void GenerateHeapNumberStub(MacroAssembler* masm); 733 void GenerateNumberStub(MacroAssembler* masm);
734 void GenerateInt32Stub(MacroAssembler* masm); 734 void GenerateInt32Stub(MacroAssembler* masm);
735 void GenerateLoadArguments(MacroAssembler* masm); 735 void GenerateLoadArguments(MacroAssembler* masm);
736 void GenerateOddballStub(MacroAssembler* masm); 736 void GenerateOddballStub(MacroAssembler* masm);
737 void GenerateRegisterArgsPush(MacroAssembler* masm); 737 void GenerateRegisterArgsPush(MacroAssembler* masm);
738 void GenerateReturn(MacroAssembler* masm); 738 void GenerateReturn(MacroAssembler* masm);
739 void GenerateSmiStub(MacroAssembler* masm); 739 void GenerateSmiStub(MacroAssembler* masm);
740 void GenerateStringStub(MacroAssembler* masm); 740 void GenerateStringStub(MacroAssembler* masm);
741 void GenerateTypeTransition(MacroAssembler* masm); 741 void GenerateTypeTransition(MacroAssembler* masm);
742 void GenerateTypeTransitionWithSavedArgs(MacroAssembler* masm); 742 void GenerateTypeTransitionWithSavedArgs(MacroAssembler* masm);
743 void GenerateUninitializedStub(MacroAssembler* masm); 743 void GenerateUninitializedStub(MacroAssembler* masm);
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
795 virtual void FinishCode(Handle<Code> code) { 795 virtual void FinishCode(Handle<Code> code) {
796 code->set_stub_info(MinorKey()); 796 code->set_stub_info(MinorKey());
797 } 797 }
798 798
799 virtual CodeStub::Major MajorKey() { return CompareIC; } 799 virtual CodeStub::Major MajorKey() { return CompareIC; }
800 virtual int MinorKey(); 800 virtual int MinorKey();
801 801
802 virtual int GetCodeKind() { return Code::COMPARE_IC; } 802 virtual int GetCodeKind() { return Code::COMPARE_IC; }
803 803
804 void GenerateSmis(MacroAssembler* masm); 804 void GenerateSmis(MacroAssembler* masm);
805 void GenerateHeapNumbers(MacroAssembler* masm); 805 void GenerateNumbers(MacroAssembler* masm);
806 void GenerateSymbols(MacroAssembler* masm); 806 void GenerateSymbols(MacroAssembler* masm);
807 void GenerateStrings(MacroAssembler* masm); 807 void GenerateStrings(MacroAssembler* masm);
808 void GenerateObjects(MacroAssembler* masm); 808 void GenerateObjects(MacroAssembler* masm);
809 void GenerateMiss(MacroAssembler* masm); 809 void GenerateMiss(MacroAssembler* masm);
810 void GenerateKnownObjects(MacroAssembler* masm); 810 void GenerateKnownObjects(MacroAssembler* masm);
811 void GenerateGeneric(MacroAssembler* masm); 811 void GenerateGeneric(MacroAssembler* masm);
812 812
813 bool strict() const { return op_ == Token::EQ_STRICT; } 813 bool strict() const { return op_ == Token::EQ_STRICT; }
814 Condition GetCondition() const { return CompareIC::ComputeCondition(op_); } 814 Condition GetCondition() const { return CompareIC::ComputeCondition(op_); }
815 815
816 virtual void AddToSpecialCache(Handle<Code> new_object); 816 virtual void AddToSpecialCache(Handle<Code> new_object);
817 virtual bool FindCodeInSpecialCache(Code** code_out, Isolate* isolate); 817 virtual bool FindCodeInSpecialCache(Code** code_out, Isolate* isolate);
818 virtual bool UseSpecialCache() { return state_ == CompareIC::KNOWN_OBJECTS; } 818 virtual bool UseSpecialCache() { return state_ == CompareIC::KNOWN_OBJECT; }
819 819
820 Token::Value op_; 820 Token::Value op_;
821 CompareIC::State left_; 821 CompareIC::State left_;
822 CompareIC::State right_; 822 CompareIC::State right_;
823 CompareIC::State state_; 823 CompareIC::State state_;
824 Handle<Map> known_map_; 824 Handle<Map> known_map_;
825 }; 825 };
826 826
827 827
828 class CEntryStub : public PlatformCodeStub { 828 class CEntryStub : public PlatformCodeStub {
(...skipping 644 matching lines...) Expand 10 before | Expand all | Expand 10 after
1473 1473
1474 // The current function entry hook. 1474 // The current function entry hook.
1475 static FunctionEntryHook entry_hook_; 1475 static FunctionEntryHook entry_hook_;
1476 1476
1477 DISALLOW_COPY_AND_ASSIGN(ProfileEntryHookStub); 1477 DISALLOW_COPY_AND_ASSIGN(ProfileEntryHookStub);
1478 }; 1478 };
1479 1479
1480 } } // namespace v8::internal 1480 } } // namespace v8::internal
1481 1481
1482 #endif // V8_CODE_STUBS_H_ 1482 #endif // V8_CODE_STUBS_H_
OLDNEW
« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | src/code-stubs.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698