Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/code-stubs.cc

Issue 12254036: Minor cleanup of CompareIC state (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Actually address all comments Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/code-stubs.h ('k') | src/ia32/code-stubs-ia32.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 176 matching lines...) Expand 10 before | Expand all | Expand 10 after
187 switch (operands_type) { 187 switch (operands_type) {
188 case BinaryOpIC::UNINITIALIZED: 188 case BinaryOpIC::UNINITIALIZED:
189 GenerateTypeTransition(masm); 189 GenerateTypeTransition(masm);
190 break; 190 break;
191 case BinaryOpIC::SMI: 191 case BinaryOpIC::SMI:
192 GenerateSmiStub(masm); 192 GenerateSmiStub(masm);
193 break; 193 break;
194 case BinaryOpIC::INT32: 194 case BinaryOpIC::INT32:
195 GenerateInt32Stub(masm); 195 GenerateInt32Stub(masm);
196 break; 196 break;
197 case BinaryOpIC::HEAP_NUMBER: 197 case BinaryOpIC::NUMBER:
198 GenerateHeapNumberStub(masm); 198 GenerateNumberStub(masm);
199 break; 199 break;
200 case BinaryOpIC::ODDBALL: 200 case BinaryOpIC::ODDBALL:
201 GenerateOddballStub(masm); 201 GenerateOddballStub(masm);
202 break; 202 break;
203 case BinaryOpIC::STRING: 203 case BinaryOpIC::STRING:
204 GenerateStringStub(masm); 204 GenerateStringStub(masm);
205 break; 205 break;
206 case BinaryOpIC::GENERIC: 206 case BinaryOpIC::GENERIC:
207 GenerateGeneric(masm); 207 GenerateGeneric(masm);
208 break; 208 break;
(...skipping 151 matching lines...) Expand 10 before | Expand all | Expand 10 after
360 360
361 361
362 void ICCompareStub::Generate(MacroAssembler* masm) { 362 void ICCompareStub::Generate(MacroAssembler* masm) {
363 switch (state_) { 363 switch (state_) {
364 case CompareIC::UNINITIALIZED: 364 case CompareIC::UNINITIALIZED:
365 GenerateMiss(masm); 365 GenerateMiss(masm);
366 break; 366 break;
367 case CompareIC::SMI: 367 case CompareIC::SMI:
368 GenerateSmis(masm); 368 GenerateSmis(masm);
369 break; 369 break;
370 case CompareIC::HEAP_NUMBER: 370 case CompareIC::NUMBER:
371 GenerateHeapNumbers(masm); 371 GenerateNumbers(masm);
372 break; 372 break;
373 case CompareIC::STRING: 373 case CompareIC::STRING:
374 GenerateStrings(masm); 374 GenerateStrings(masm);
375 break; 375 break;
376 case CompareIC::SYMBOL: 376 case CompareIC::SYMBOL:
377 GenerateSymbols(masm); 377 GenerateSymbols(masm);
378 break; 378 break;
379 case CompareIC::OBJECT: 379 case CompareIC::OBJECT:
380 GenerateObjects(masm); 380 GenerateObjects(masm);
381 break; 381 break;
382 case CompareIC::KNOWN_OBJECTS: 382 case CompareIC::KNOWN_OBJECT:
383 ASSERT(*known_map_ != NULL); 383 ASSERT(*known_map_ != NULL);
384 GenerateKnownObjects(masm); 384 GenerateKnownObjects(masm);
385 break; 385 break;
386 case CompareIC::GENERIC: 386 case CompareIC::GENERIC:
387 GenerateGeneric(masm); 387 GenerateGeneric(masm);
388 break; 388 break;
389 } 389 }
390 } 390 }
391 391
392 392
(...skipping 236 matching lines...) Expand 10 before | Expand all | Expand 10 after
629 // already active, as the hooks won't stack. 629 // already active, as the hooks won't stack.
630 if (entry_hook != 0 && entry_hook_ != 0) 630 if (entry_hook != 0 && entry_hook_ != 0)
631 return false; 631 return false;
632 632
633 entry_hook_ = entry_hook; 633 entry_hook_ = entry_hook;
634 return true; 634 return true;
635 } 635 }
636 636
637 637
638 } } // namespace v8::internal 638 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/code-stubs.h ('k') | src/ia32/code-stubs-ia32.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698