Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1225403010: Reduce usage of CSSParserValueList::size (Closed)

Created:
5 years, 5 months ago by rwlbuis
Modified:
5 years, 4 months ago
Reviewers:
Timothy Loh
CC:
blink-reviews, dglazkov+blink, rwlbuis, apavlov+blink_chromium.org, blink-reviews-css, darktears
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Reduce usage of CSSParserValueList::size Since CSSParserTokenRange represents a stream, calling something like size on it makes no sense. So change the logic in these places to not call size by checking for end of the value list. BUG=499780 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200741

Patch Set 1 #

Patch Set 2 : Fix test #

Patch Set 3 : Remove hasSingleValue change #

Patch Set 4 : Fix warning #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -45 lines) Patch
M Source/core/css/parser/CSSPropertyParser.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 1 2 3 10 chunks +28 lines, -44 lines 0 comments Download

Messages

Total messages: 24 (13 generated)
rwlbuis
PTAL
5 years, 4 months ago (2015-08-17 22:46:19 UTC) #2
Timothy Loh
On 2015/08/17 22:46:19, rwlbuis wrote: > PTAL lgtm
5 years, 4 months ago (2015-08-18 01:53:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1225403010/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1225403010/40001
5 years, 4 months ago (2015-08-18 02:22:54 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/94440)
5 years, 4 months ago (2015-08-18 02:45:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1225403010/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1225403010/40001
5 years, 4 months ago (2015-08-18 12:02:09 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/71709)
5 years, 4 months ago (2015-08-18 12:41:38 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1225403010/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1225403010/40001
5 years, 4 months ago (2015-08-18 14:22:35 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1225403010/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1225403010/60001
5 years, 4 months ago (2015-08-18 14:26:22 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/86520)
5 years, 4 months ago (2015-08-18 14:35:56 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1225403010/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1225403010/80001
5 years, 4 months ago (2015-08-18 15:28:21 UTC) #23
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 18:45:46 UTC) #24
Message was sent while issue was closed. 
Committed patchset #4 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200741

Powered by Google App Engine
This is Rietveld 408576698