Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1225403006: Move autofill tests chrome ChromeShellTest to ChromePublicTest (Closed)

Created:
5 years, 5 months ago by pkotwicz
Modified:
5 years, 5 months ago
CC:
browser-components-watch_chromium.org, chromium-reviews, estade+watch_chromium.org, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move autofill tests chrome ChromeShellTest to ChromePublicTest BUG=505040 TEST=None TBR=aurimas Committed: https://crrev.com/5c753e41f31fe7f9acb0a3793bd08cc0cda3607d Cr-Commit-Position: refs/heads/master@{#339315}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -1978 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogControllerAndroid.java View 3 chunks +3 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogResult.java View 4 chunks +4 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillLogger.java View 3 chunks +4 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java View 10 chunks +10 lines, -0 lines 0 comments Download
A + chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillDialogControllerTest.java View 6 chunks +19 lines, -12 lines 0 comments Download
A + chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillPopupTest.java View 5 chunks +15 lines, -6 lines 0 comments Download
A + chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillPopupWithKeyboardTest.java View 6 chunks +17 lines, -7 lines 0 comments Download
A + chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillTest.java View 2 chunks +14 lines, -7 lines 0 comments Download
A + chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillTestHelper.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/javatests/src/org/chromium/chrome/browser/autofill/MockAutofillDialogController.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/javatests/src/org/chromium/chrome/browser/autofill/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/javatests/src/org/chromium/chrome/browser/autofill/PersonalDataManagerTest.java View 2 chunks +5 lines, -5 lines 0 comments Download
D chrome/android/javatests_shell/src/org/chromium/chrome/browser/autofill/AutofillDialogControllerTest.java View 1 chunk +0 lines, -733 lines 0 comments Download
D chrome/android/javatests_shell/src/org/chromium/chrome/browser/autofill/AutofillPopupTest.java View 1 chunk +0 lines, -354 lines 0 comments Download
D chrome/android/javatests_shell/src/org/chromium/chrome/browser/autofill/AutofillPopupWithKeyboardTest.java View 1 chunk +0 lines, -146 lines 0 comments Download
D chrome/android/javatests_shell/src/org/chromium/chrome/browser/autofill/AutofillTest.java View 1 chunk +0 lines, -151 lines 0 comments Download
D chrome/android/javatests_shell/src/org/chromium/chrome/browser/autofill/AutofillTestHelper.java View 1 chunk +0 lines, -140 lines 0 comments Download
D chrome/android/javatests_shell/src/org/chromium/chrome/browser/autofill/MockAutofillDialogController.java View 1 chunk +0 lines, -141 lines 0 comments Download
D chrome/android/javatests_shell/src/org/chromium/chrome/browser/autofill/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/android/javatests_shell/src/org/chromium/chrome/browser/autofill/PersonalDataManagerTest.java View 1 chunk +0 lines, -277 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
pkotwicz
aurimas@ PTAL
5 years, 5 months ago (2015-07-16 00:55:13 UTC) #3
aurimas (slooooooooow)
lgtm
5 years, 5 months ago (2015-07-16 18:26:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1225403006/20001
5 years, 5 months ago (2015-07-17 18:39:52 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/79838)
5 years, 5 months ago (2015-07-17 18:58:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1225403006/20001
5 years, 5 months ago (2015-07-17 20:01:28 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 5 months ago (2015-07-17 20:20:22 UTC) #11
commit-bot: I haz the power
5 years, 5 months ago (2015-07-17 20:21:25 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/5c753e41f31fe7f9acb0a3793bd08cc0cda3607d
Cr-Commit-Position: refs/heads/master@{#339315}

Powered by Google App Engine
This is Rietveld 408576698