Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 1225403005: Special printing for type feedback vectors. (Closed)

Created:
5 years, 5 months ago by mvstanton
Modified:
5 years, 5 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Special printing for type feedback vectors. Gdb macro jfv on an object will print it as a feedback vector. Printouts look like this: DebugPrint: 0x5dc0d2ad: [TypeFeedbackVector] - length: 12 - ics with type info: 3 - generic ics: 0 ICSlot 0 CALL_IC MONOMORPHIC [4]: 0x5dc0d365 WeakCell for 0x5dc0cd69 <JS Function foo (SharedFunctionInfo 0x5dc0cb0d)> [5]: 0x4203c4c1 <Code: HANDLER> ICSlot 1 LOAD_IC MONOMORPHIC [6]: 0x5dc0d1f5 WeakCell for 0x3a710481 <Map(FAST_HOLEY_SMI_ELEMENTS)> [7]: 0x4203a1c1 <Code: HANDLER> ICSlot 2 LOAD_IC UNINITIALIZED [8]: 0x3060d045 <Symbol: 711234650 <String[20]: uninitialized_symbol>> [9]: 0x3060d045 <Symbol: 711234650 <String[20]: uninitialized_symbol>> ICSlot 3 LOAD_IC MONOMORPHIC [10]: 0x5dc0d3b5 WeakCell for 0x3a710d71 <Map(FAST_HOLEY_ELEMENTS)> [11]: 0x4202af01 <Code: HANDLER> BUG= Committed: https://crrev.com/9386b861fda66cd36125c36ab63909784cc409db Cr-Commit-Position: refs/heads/master@{#29679}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -1 line) Patch
M src/objects-printer.cc View 2 chunks +56 lines, -1 line 0 comments Download
M src/type-feedback-vector.h View 1 chunk +7 lines, -0 lines 0 comments Download
M tools/gdbinit View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mvstanton
Hi Benedikt, Here is the printing function we discussed a little while ago.
5 years, 5 months ago (2015-07-15 10:49:39 UTC) #2
Benedikt Meurer
Nice. LGTM!
5 years, 5 months ago (2015-07-15 11:03:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1225403005/1
5 years, 5 months ago (2015-07-15 11:53:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-15 12:22:01 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-15 12:22:10 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9386b861fda66cd36125c36ab63909784cc409db
Cr-Commit-Position: refs/heads/master@{#29679}

Powered by Google App Engine
This is Rietveld 408576698