Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(699)

Unified Diff: chrome/browser/resources/file_manager/js/metadata/id3_parser.js

Issue 12254008: Files.app: Add missing JSdoc for member methods/variables #2. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/file_manager/js/metadata/id3_parser.js
diff --git a/chrome/browser/resources/file_manager/js/metadata/id3_parser.js b/chrome/browser/resources/file_manager/js/metadata/id3_parser.js
index e90380cc1ab55c3213188f30d55965eddc93189c..36ac55bb942527b54239e5dbd420bedcb122fa2c 100644
--- a/chrome/browser/resources/file_manager/js/metadata/id3_parser.js
+++ b/chrome/browser/resources/file_manager/js/metadata/id3_parser.js
@@ -124,6 +124,10 @@ Id3Parser.prototype.readUserDefinedTextFrame_ = function(reader,
/**
* @private
+ * @param {ByteReader} reader Reader to use.
+ * @param {number} majorVersion Major id3 version to use.
+ * @param {Object} frame Frame so store data at.
+ * @param {number} end Frame end position in reader.
*/
Id3Parser.prototype.readPIC_ = function(reader, majorVersion, frame, end) {
frame.encoding = reader.readScalar(1, false, end);
@@ -143,6 +147,10 @@ Id3Parser.prototype.readPIC_ = function(reader, majorVersion, frame, end) {
/**
* @private
+ * @param {ByteReader} reader Reader to use.
+ * @param {number} majorVersion Major id3 version to use.
+ * @param {Object} frame Frame so store data at.
+ * @param {number} end Frame end position in reader.
*/
Id3Parser.prototype.readAPIC_ = function(reader, majorVersion, frame, end) {
this.vlog('Extracting picture');
@@ -227,6 +235,12 @@ Id3Parser.prototype.readFrame_ = function(reader, majorVersion) {
return frame;
};
+/**
+ * @param {File} file //TODO(JSDOC).
+ * @param {Object} metadata //TODO(JSDOC).
+ * @param {function(Object)} callback //TODO(JSDOC).
+ * @param {function(etring)} onError //TODO(JSDOC).
+ */
Id3Parser.prototype.parse = function(file, metadata, callback, onError) {
var self = this;

Powered by Google App Engine
This is Rietveld 408576698