Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2623)

Unified Diff: chrome/browser/resources/file_manager/js/metadata/byte_reader.js

Issue 12254008: Files.app: Add missing JSdoc for member methods/variables #2. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/file_manager/js/metadata/exif_parser.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/file_manager/js/metadata/byte_reader.js
diff --git a/chrome/browser/resources/file_manager/js/metadata/byte_reader.js b/chrome/browser/resources/file_manager/js/metadata/byte_reader.js
index 66d36841b9b4c404b0b63fd37944dc0cb2c554d8..58a33c7f590ca2176e2fcc04b7c37ed23286070d 100644
--- a/chrome/browser/resources/file_manager/js/metadata/byte_reader.js
+++ b/chrome/browser/resources/file_manager/js/metadata/byte_reader.js
@@ -13,12 +13,37 @@ function ByteReader(arrayBuffer, opt_offset, opt_length) {
// Static const and methods.
-ByteReader.LITTLE_ENDIAN = 0; // Intel, 0x1234 is [0x34, 0x12]
-ByteReader.BIG_ENDIAN = 1; // Motorola, 0x1234 is [0x12, 0x34]
+/**
+ * Intel, 0x1234 is [0x34, 0x12]
+ * @const
+ * @type {number}
+ */
+ByteReader.LITTLE_ENDIAN = 0;
+/**
+ * Motorola, 0x1234 is [0x12, 0x34]
+ * @const
+ * @type {number}
+ */
+ByteReader.BIG_ENDIAN = 1;
-ByteReader.SEEK_BEG = 0; // Seek relative to the beginning of the buffer.
-ByteReader.SEEK_CUR = 1; // Seek relative to the current position.
-ByteReader.SEEK_END = 2; // Seek relative to the end of the buffer.
+/**
+ * Seek relative to the beginning of the buffer.
+ * @const
+ * @type {number}
+ */
+ByteReader.SEEK_BEG = 0;
+/**
+ * Seek relative to the current position.
+ * @const
+ * @type {number}
+ */
+ByteReader.SEEK_CUR = 1;
+/**
+ * Seek relative to the end of the buffer.
+ * @const
+ * @type {number}
+ */
+ByteReader.SEEK_END = 2;
/**
* Throw an error if (0 > pos >= end) or if (pos + size > end).
@@ -99,6 +124,11 @@ ByteReader.readNullTerminatedStringUTF16 = function(
return String.fromCharCode.apply(null, codes);
};
+/**
+ * @const
+ * @type {Array.<string>}
+ * @private
+ */
ByteReader.base64Alphabet_ =
('ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/').
split('');
@@ -225,6 +255,12 @@ ByteReader.prototype.validateRead = function(size, opt_end) {
ByteReader.validateRead(this.view_, this.pos_, size, opt_end);
};
+/**
+ * @param {number} width //TODO(JSDOC).
+ * @param {boolean=} opt_signed //TODO(JSDOC).
+ * @param {number=} opt_end //TODO(JSDOC).
+ * @return {string} //TODO(JSDOC).
+ */
ByteReader.prototype.readScalar = function(width, opt_signed, opt_end) {
var method = opt_signed ? 'getInt' : 'getUint';
« no previous file with comments | « no previous file | chrome/browser/resources/file_manager/js/metadata/exif_parser.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698