tests/corelib/map_from_test.dart - Issue 12254006: Reapply "New implementation of {,Linked}Hash{Set,Map}."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/corelib/map_from_test.dart

Issue 12254006: Reapply "New implementation of {,Linked}Hash{Set,Map}." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Make HashMap and LinkedHashMap not extend HashTable. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tests/corelib/map_from_test.dart

diff --git a/tests/corelib/map_from_test.dart b/tests/corelib/map_from_test.dart

index bc47e9d448ce817cdab6e4fd9488e0939a24cd0f..17896ac85ee8248af77d866a8920be6c5b8bab14 100644

--- a/tests/corelib/map_from_test.dart

+++ b/tests/corelib/map_from_test.dart

@@ -71,7 +71,7 @@ testWithLinkedMap() {

var map = const { 'b': 1, 'a': 2, 'c': 3 };

var otherMap = new LinkedHashMap.from(map);

Expect.isTrue(otherMap is Map);

- Expect.isTrue(otherMap is HashMap);

+ Expect.isTrue(otherMap is !HashMap);

floitsch 2013/02/13 15:54:06 we usually put the "!" with the "is".

Lasse Reichstein Nielsen 2013/02/14 10:18:12 Done.

Expect.isTrue(otherMap is LinkedHashMap);

var i = 1;

for (var val in map.values) {

« sdk/lib/collection/linked_hash_set.dart ('K') | « tests/corelib/hash_set_test.dart ('k') | no next file » | no next file with comments »