Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(6)

Issue 12254005: Merge 141769 (Closed)

Created:
6 years, 9 months ago by Sami
Modified:
6 years, 9 months ago
Reviewers:
Sami
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1364/
Visibility:
Public.

Description

Merge 141769 > Disable -webkit-overflow-scrolling CSS attribute on Chromium > https://bugs.webkit.org/show_bug.cgi?id=108020 > > Patch by Sami Kyostila <skyostil@chromium.org>; on 2013-02-04 > Reviewed by James Robinson. > > Now that we can automatically promote overflow elements to accelerated > scrolling layers there is no use for the -webkit-overflow-scrolling CSS > attribute any longer on Chromium. > > Source/WebKit/chromium: > > This patch enables composited overflow scrolling in > ScrollingCoordinatorChromiumTest. Because this also causes the overflow div > in non-fast-scrollable.html to become composited, we also need to modify that > test to opt it out of composited scrolling. > > * features.gypi: > * tests/ScrollingCoordinatorChromiumTest.cpp: > (WebKit::ScrollingCoordinatorChromiumTest::ScrollingCoordinatorChromiumTest): > (WebKit::TEST_F): > * tests/data/non-fast-scrollable.html: > * tests/data/overflow-scrolling.html: Renamed from Source/WebKit/chromium/tests/data/touch-overflow-scrolling.html. > > LayoutTests: > > The following tests using -webkit-overflow-scroll are modified to also call > setAcceleratedCompositingForOverflowScrollEnabled(). This makes them test > meaningful things on also on platforms that do not support that CSS attribute. > > * compositing/overflow/clipping-ancestor-with-accelerated-scrolling-ancestor.html: > * compositing/overflow/iframe-inside-overflow-clipping.html: > * compositing/overflow/nested-scrolling.html: > * compositing/overflow/overflow-clip-with-accelerated-scrolling-ancestor.html: > * compositing/overflow/scrolling-content-clip-to-viewport.html: > * compositing/overflow/scrolling-without-painting.html: > * compositing/overflow/textarea-scroll-touch.html: > * compositing/overflow/updating-scrolling-content.html: > * platform/chromium-android/compositing/layer-creation/overflow-scrolling-touch-expected.txt: Removed. > * platform/chromium-android/compositing/layer-creation/overflow-scrolling-touch.html: Removed. > * platform/chromium-linux/compositing/overflow/nested-scrolling-expected.png: > * platform/chromium/TestExpectations: > * platform/chromium/compositing/overflow/overflow-auto-with-touch-toggle-expected.txt: Removed. > * platform/chromium/compositing/overflow/overflow-scrolling-touch-stacking-context-expected.png: Removed. > * platform/chromium/compositing/overflow/overflow-scrolling-touch-stacking-context-expected.txt: Removed. > * platform/chromium/compositing/overflow/overflow-scrolling-touch-stacking-context.html: Removed. > * platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/overflow-auto-with-touch-toggle-expected.txt: Removed. TBR=skyostil@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=142740

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -156 lines) Patch
M LayoutTests/compositing/overflow/clipping-ancestor-with-accelerated-scrolling-ancestor.html View 1 chunk +4 lines, -0 lines 0 comments Download
M LayoutTests/compositing/overflow/iframe-inside-overflow-clipping.html View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/compositing/overflow/nested-scrolling.html View 1 chunk +4 lines, -0 lines 0 comments Download
M LayoutTests/compositing/overflow/overflow-clip-with-accelerated-scrolling-ancestor.html View 1 chunk +4 lines, -0 lines 0 comments Download
M LayoutTests/compositing/overflow/scrolling-content-clip-to-viewport.html View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/compositing/overflow/scrolling-without-painting.html View 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/compositing/overflow/textarea-scroll-touch.html View 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/compositing/overflow/updating-scrolling-content.html View 1 chunk +3 lines, -0 lines 0 comments Download
D LayoutTests/platform/chromium-android/compositing/layer-creation/overflow-scrolling-touch.html View 1 chunk +0 lines, -61 lines 0 comments Download
M LayoutTests/platform/chromium-linux/compositing/overflow/nested-scrolling-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium/TestExpectations View 2 chunks +2 lines, -15 lines 0 comments Download
D LayoutTests/platform/chromium/compositing/overflow/overflow-auto-with-touch-toggle-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/platform/chromium/compositing/overflow/overflow-scrolling-touch-stacking-context.html View 1 chunk +0 lines, -35 lines 0 comments Download
D LayoutTests/platform/chromium/compositing/overflow/overflow-scrolling-touch-stacking-context-expected.png View Binary file 0 comments Download
D LayoutTests/platform/chromium/compositing/overflow/overflow-scrolling-touch-stacking-context-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
M Source/WebKit/chromium/features.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebKit/chromium/tests/ScrollingCoordinatorChromiumTest.cpp View 4 chunks +4 lines, -7 lines 0 comments Download
M Source/WebKit/chromium/tests/data/non-fast-scrollable.html View 1 chunk +8 lines, -2 lines 0 comments Download
A + Source/WebKit/chromium/tests/data/overflow-scrolling.html View 0 chunks +-1 lines, --1 lines 0 comments Download
D Source/WebKit/chromium/tests/data/touch-overflow-scrolling.html View 1 chunk +0 lines, -23 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Sami
6 years, 9 months ago (2013-02-13 13:57:07 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698