Issue 1225393003: Refactor mojo_android_application

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1225393003: Refactor mojo_android_application (Closed)

Created:
5 years, 5 months ago by qsr

Modified:
5 years, 5 months ago

Reviewers:
ppi

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Refactor mojo_android_application This relands the following CLs: https://codereview.chromium.org/1233883003 https://codereview.chromium.org/1227953007 It fixes the issue with the dex file not having the correct name. TBR=ppi@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/5227b63e0ba175501b76b1104e26085e203dda9b

Patch Set 1 #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+122 lines, -82 lines)			Patch
M	examples/device_name/BUILD.gn	View	2 chunks	+6 lines, -27 lines	0 comments	Download
M	mojo/public/mojo_application.gni	View	4 chunks	+106 lines, -21 lines	0 comments	Download
M	services/android/BUILD.gn	View	2 chunks	+8 lines, -34 lines	0 comments	Download
M	shell/android/apk/src/org/chromium/mojo/shell/AndroidHandler.java	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

qsr

5 years, 5 months ago (2015-07-16 16:00:40 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
5227b63e0ba175501b76b1104e26085e203dda9b.

Expand Messages | Collapse Messages