Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Side by Side Diff: lib/src/internal_style.dart

Issue 1225373003: Fix path.toUri for relative paths. (Closed) Base URL: git@github.com:dart-lang/path@master
Patch Set: merge Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « CHANGELOG.md ('k') | pubspec.yaml » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library path.internal_style; 5 library path.internal_style;
6 6
7 import 'context.dart'; 7 import 'context.dart';
8 import 'style.dart'; 8 import 'style.dart';
9 9
10 /// The internal interface for the [Style] type. 10 /// The internal interface for the [Style] type.
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
50 50
51 /// Returns whether [path] is root-relative. 51 /// Returns whether [path] is root-relative.
52 /// 52 ///
53 /// If [path] is relative or absolute and not root-relative, returns `false`. 53 /// If [path] is relative or absolute and not root-relative, returns `false`.
54 bool isRootRelative(String path); 54 bool isRootRelative(String path);
55 55
56 /// Returns the path represented by [uri] in this style. 56 /// Returns the path represented by [uri] in this style.
57 String pathFromUri(Uri uri); 57 String pathFromUri(Uri uri);
58 58
59 /// Returns the URI that represents the relative path made of [parts]. 59 /// Returns the URI that represents the relative path made of [parts].
60 Uri relativePathToUri(String path) => 60 Uri relativePathToUri(String path) {
61 new Uri(pathSegments: context.split(path)); 61 var segments = context.split(path);
62
63 // Ensure that a trailing slash in the path produces a trailing slash in the
64 // URL.
65 if (isSeparator(path.codeUnitAt(path.length - 1))) segments.add('');
66 return new Uri(pathSegments: segments);
67 }
62 68
63 /// Returns the URI that represents [path], which is assumed to be absolute. 69 /// Returns the URI that represents [path], which is assumed to be absolute.
64 Uri absolutePathToUri(String path); 70 Uri absolutePathToUri(String path);
65 } 71 }
OLDNEW
« no previous file with comments | « CHANGELOG.md ('k') | pubspec.yaml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698