Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1006)

Issue 1225373003: Fix path.toUri for relative paths. (Closed)

Created:
5 years, 5 months ago by nweiz
Modified:
5 years, 5 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/path@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix path.toUri for relative paths. It wasn't preserving trailing slashes, which was a problem when passing packageRoot URLs to dart2js. R=rnystrom@google.com Committed: https://github.com/dart-lang/path/commit/fddebbe9c15905f384d4e56fe96f8b56359a5e81

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M CHANGELOG.md View 1 1 chunk +4 lines, -0 lines 0 comments Download
M lib/src/internal_style.dart View 1 chunk +8 lines, -2 lines 0 comments Download
M pubspec.yaml View 1 1 chunk +1 line, -1 line 0 comments Download
M test/posix_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M test/url_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M test/windows_test.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
5 years, 5 months ago (2015-07-09 20:46:28 UTC) #1
Bob Nystrom
lgtm
5 years, 5 months ago (2015-07-09 20:47:52 UTC) #2
nweiz
5 years, 5 months ago (2015-07-09 20:49:08 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
fddebbe9c15905f384d4e56fe96f8b56359a5e81 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698