Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2198)

Unified Diff: android_webview/browser/aw_quota_permission_context.cc

Issue 12253057: Implement WebStorage API methods (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address nits Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/browser/aw_quota_permission_context.cc
diff --git a/android_webview/browser/aw_quota_permission_context.cc b/android_webview/browser/aw_quota_permission_context.cc
index ce3a2c34945c2f351fc6ec17ec22ee94b88c02ad..544edbc7329319de01c80214e5d5bc6f548e4535 100644
--- a/android_webview/browser/aw_quota_permission_context.cc
+++ b/android_webview/browser/aw_quota_permission_context.cc
@@ -23,14 +23,10 @@ void AwQuotaPermissionContext::RequestQuotaPermission(
int render_process_id,
int render_view_id,
const PermissionCallback& callback) {
- if (type != quota::kStorageTypePersistent) {
- callback.Run(QUOTA_PERMISSION_RESPONSE_DISALLOW);
- } else {
- // TODO(boliu): Implement this to power
- // WebChromeClient.onExceededDatabaseQuota
- NOTIMPLEMENTED();
- callback.Run(QUOTA_PERMISSION_RESPONSE_CANCELLED);
- }
+ // Android WebView only uses quota::kStorageTypeTemporary type of storage
+ // with quota managed automatically, not through this interface. Therefore
+ // unconditionally disallow all quota requests here.
+ callback.Run(QUOTA_PERMISSION_RESPONSE_DISALLOW);
}
} // namespace android_webview
« no previous file with comments | « android_webview/browser/aw_quota_manager_bridge.cc ('k') | android_webview/browser/jni_dependency_factory.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698