android_webview/browser/aw_quota_manager_bridge.h - Issue 12253057: Implement WebStorage API methods

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: android_webview/browser/aw_quota_manager_bridge.h

Issue 12253057: Implement WebStorage API methods (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rearrange usage/quota Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « android_webview/browser/aw_content_browser_client.cc ('k') | android_webview/browser/aw_quota_manager_bridge.cc » ('j') | android_webview/browser/aw_quota_permission_context.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef ANDROID_WEBVIEW_BROWSER_AW_QUOTA_MANAGER_BRIDGE_H_

	6 #define ANDROID_WEBVIEW_BROWSER_AW_QUOTA_MANAGER_BRIDGE_H_

	7

	8 namespace android_webview {

	9

	10 // Empty super class so this can be owned by AwBrowserContext.
	mnaganov (inactive) 2013/02/20 09:29:03 I don't understand the usage of "super" here. Does I don't understand the usage of "super" here. Does this class act as a superclass for other classes? I didn't see any. mkosiba (inactive) 2013/02/20 12:21:38 probably "base class" is a better name. I'm assumi Show quoted text On 2013/02/20 09:29:03, Mikhail Naganov (Chromium) wrote: > I don't understand the usage of "super" here. Does this class act as a > superclass for other classes? I didn't see any. probably "base class" is a better name. I'm assuming the idea is that you need the public destructor for AwBrowserContext to be able to destroy the bridge. Maybe add that to the comment so it's super-obvious :) boliu 2013/02/20 20:14:16 Martin's completely right. Updated comment. Show quoted text On 2013/02/20 12:21:38, Martin Kosiba wrote: > On 2013/02/20 09:29:03, Mikhail Naganov (Chromium) wrote: > > I don't understand the usage of "super" here. Does this class act as a > > superclass for other classes? I didn't see any. > > probably "base class" is a better name. I'm assuming the idea is that you need > the public destructor for AwBrowserContext to be able to destroy the bridge. > Maybe add that to the comment so it's super-obvious :) Martin's completely right. Updated comment.
	11 class AwQuotaManagerBridge {

	12 public:

	13 virtual ~AwQuotaManagerBridge();

	14 };

	15

	16 } // namespace android_webview

	17

	18 #endif // ANDROID_WEBVIEW_BROWSER_AW_QUOTA_MANAGER_BRIDGE_H_

OLD	NEW