Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1153)

Unified Diff: utils/tests/pub/validator_test.dart

Issue 12253054: Get rid of join() and encapsulate File and Directory in io.dart. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Rebase. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « utils/tests/pub/test_pub.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/tests/pub/validator_test.dart
diff --git a/utils/tests/pub/validator_test.dart b/utils/tests/pub/validator_test.dart
index ab67f7713e25bf4e7f345575b9d16b6d1a263ea0..3dbb5adef147ac198579e2c8a0c01712cc6f32b5 100644
--- a/utils/tests/pub/validator_test.dart
+++ b/utils/tests/pub/validator_test.dart
@@ -9,11 +9,12 @@ import 'dart:io';
import 'dart:json' as json;
import 'dart:math' as math;
-import 'test_pub.dart';
import '../../../pkg/http/lib/http.dart' as http;
import '../../../pkg/http/lib/testing.dart';
import '../../../pkg/path/lib/path.dart' as path;
import '../../../pkg/unittest/lib/unittest.dart';
+
+import 'test_pub.dart';
import '../../pub/entrypoint.dart';
import '../../pub/io.dart';
import '../../pub/validator.dart';
@@ -115,20 +116,20 @@ main() {
});
integration('has a COPYING file', () {
- file(join(appPath, 'LICENSE'), '').scheduleDelete();
- file(join(appPath, 'COPYING'), '').scheduleCreate();
+ file(path.join(appPath, 'LICENSE'), '').scheduleDelete();
+ file(path.join(appPath, 'COPYING'), '').scheduleCreate();
expectNoValidationError(license);
});
integration('has a prefixed LICENSE file', () {
- file(join(appPath, 'LICENSE'), '').scheduleDelete();
- file(join(appPath, 'MIT_LICENSE'), '').scheduleCreate();
+ file(path.join(appPath, 'LICENSE'), '').scheduleDelete();
+ file(path.join(appPath, 'MIT_LICENSE'), '').scheduleCreate();
expectNoValidationError(license);
});
integration('has a suffixed LICENSE file', () {
- file(join(appPath, 'LICENSE'), '').scheduleDelete();
- file(join(appPath, 'LICENSE.md'), '').scheduleCreate();
+ file(path.join(appPath, 'LICENSE'), '').scheduleDelete();
+ file(path.join(appPath, 'LICENSE.md'), '').scheduleCreate();
expectNoValidationError(license);
});
@@ -272,7 +273,7 @@ main() {
});
integration('has no LICENSE file', () {
- file(join(appPath, 'LICENSE'), '').scheduleDelete();
+ file(path.join(appPath, 'LICENSE'), '').scheduleDelete();
expectValidationError(license);
});
@@ -334,7 +335,7 @@ main() {
});
integration('has a single library named differently than the package', () {
- file(join(appPath, "lib", "test_pkg.dart"), '').scheduleDelete();
+ file(path.join(appPath, "lib", "test_pkg.dart"), '').scheduleDelete();
dir(appPath, [
dir("lib", [file("best_pkg.dart", "int i = 0;")])
]).scheduleCreate();
@@ -342,17 +343,17 @@ main() {
});
integration('has no lib directory', () {
- dir(join(appPath, "lib")).scheduleDelete();
+ dir(path.join(appPath, "lib")).scheduleDelete();
expectValidationError(lib);
});
integration('has an empty lib directory', () {
- file(join(appPath, "lib", "test_pkg.dart"), '').scheduleDelete();
+ file(path.join(appPath, "lib", "test_pkg.dart"), '').scheduleDelete();
expectValidationError(lib);
});
integration('has a lib directory containing only src', () {
- file(join(appPath, "lib", "test_pkg.dart"), '').scheduleDelete();
+ file(path.join(appPath, "lib", "test_pkg.dart"), '').scheduleDelete();
dir(appPath, [
dir("lib", [
dir("src", [file("test_pkg.dart", "int i = 0;")])
« no previous file with comments | « utils/tests/pub/test_pub.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698