Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: utils/pub/source.dart

Issue 12253054: Get rid of join() and encapsulate File and Directory in io.dart. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Rebase. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « utils/pub/sdk_source.dart ('k') | utils/pub/system_cache.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/pub/source.dart
diff --git a/utils/pub/source.dart b/utils/pub/source.dart
index 30fd5ebbebdbca61ebc9368357caf32366cbe5df..1fd93271282a4f9412aead2e1b28675386aa4d0d 100644
--- a/utils/pub/source.dart
+++ b/utils/pub/source.dart
@@ -47,7 +47,7 @@ abstract class Source {
/// The root directory of this source's cache within the system cache.
///
/// This shouldn't be overridden by subclasses.
- String get systemCacheRoot => join(systemCache.rootDir, name);
+ String get systemCacheRoot => path.join(systemCache.rootDir, name);
/// Records the system cache to which this source belongs.
///
@@ -144,9 +144,9 @@ abstract class Source {
/// * It has no pubspec.
Future<bool> _isCachedPackageCorrupted(String packageDir) {
return defer(() {
- if (!fileExists(join(packageDir, "pubspec.yaml"))) return true;
+ if (!fileExists(path.join(packageDir, "pubspec.yaml"))) return true;
- var libDir = join(packageDir, "lib");
+ var libDir = path.join(packageDir, "lib");
if (dirExists(libDir)) {
return listDir(libDir).then((contents) => contents.length == 0);
}
« no previous file with comments | « utils/pub/sdk_source.dart ('k') | utils/pub/system_cache.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698