Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Side by Side Diff: utils/pub/sdk_source.dart

Issue 12253054: Get rid of join() and encapsulate File and Directory in io.dart. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Rebase. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « utils/pub/sdk.dart ('k') | utils/pub/source.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library sdk_source; 5 library sdk_source;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8
9 import '../../pkg/path/lib/path.dart' as path;
10
8 import 'io.dart'; 11 import 'io.dart';
9 import 'package.dart'; 12 import 'package.dart';
10 import 'pubspec.dart'; 13 import 'pubspec.dart';
11 import 'sdk.dart' as sdk; 14 import 'sdk.dart' as sdk;
12 import 'source.dart'; 15 import 'source.dart';
13 import 'utils.dart'; 16 import 'utils.dart';
14 import 'version.dart'; 17 import 'version.dart';
15 18
16 /// A package source that uses libraries from the Dart SDK. 19 /// A package source that uses libraries from the Dart SDK.
17 class SdkSource extends Source { 20 class SdkSource extends Source {
(...skipping 20 matching lines...) Expand all
38 var path = _getPackagePath(id); 41 var path = _getPackagePath(id);
39 if (path == null) return false; 42 if (path == null) return false;
40 43
41 return createPackageSymlink(id.name, path, destPath).then((_) => true); 44 return createPackageSymlink(id.name, path, destPath).then((_) => true);
42 }); 45 });
43 } 46 }
44 47
45 /// Gets the path in the SDK's "pkg" directory to the directory containing 48 /// Gets the path in the SDK's "pkg" directory to the directory containing
46 /// package [id]. Returns `null` if the package could not be found. 49 /// package [id]. Returns `null` if the package could not be found.
47 String _getPackagePath(PackageId id) { 50 String _getPackagePath(PackageId id) {
48 var pkgPath = join(sdk.rootDirectory, "pkg", id.description); 51 var pkgPath = path.join(sdk.rootDirectory, "pkg", id.description);
49 return dirExists(pkgPath) ? pkgPath : null; 52 return dirExists(pkgPath) ? pkgPath : null;
50 } 53 }
51 } 54 }
OLDNEW
« no previous file with comments | « utils/pub/sdk.dart ('k') | utils/pub/source.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698