Issue 12253048: Add back --disallow-unsafe-eval for M3. This flag will be temporarily disabled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12253048: Add back --disallow-unsafe-eval for M3. This flag will be temporarily disabled (Closed)

Created:
7 years, 10 months ago by dgrove

Modified:
5 years, 10 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org, ahe, kasperl

Base URL:
http://dart.googlecode.com/svn/trunk/dart/

Visibility:
Public.

Add back --disallow-unsafe-eval for M3. This flag will be temporarily disabled soon after the M3 build is cut, until it can be properly tested.

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -18 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/dart2js.dart	View	3 chunks	+1 line, -14 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/backend.dart	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/js_backend.dart	View	1 chunk	+1 line, -2 lines	0 comments	Download

Total messages: 2 (0 generated)

dgrove

I'll be OOO on Friday, so Emily will land this in trunk. I've run all ...

7 years, 10 months ago (2013-02-14 22:06:48 UTC) #1

Emily Fortuna

7 years, 10 months ago (2013-02-15 23:15:45 UTC) #2

lgtm. 

committed here: https://codereview.chromium.org//12280012 in revision 18601