chrome/common/extensions/api/extension_action/script_badge_handler.h - Issue 12253022: Manifest handler for all keys background-related.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/extension_action/script_badge_handler.h

Issue 12253022: Manifest handler for all keys background-related. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/api/extension_action/page_action_manifest_unittest.cc ('k') | chrome/common/extensions/api/extension_action/script_badge_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/extension_action/script_badge_handler.h

diff --git a/chrome/common/extensions/api/extension_action/script_badge_handler.h b/chrome/common/extensions/api/extension_action/script_badge_handler.h

index d539aafc693339c97d09b15559eb86cba0d8000f..cd742bc03c14b77051d14a0808ef325f6ab1e5dc 100644

--- a/chrome/common/extensions/api/extension_action/script_badge_handler.h

+++ b/chrome/common/extensions/api/extension_action/script_badge_handler.h

@@ -20,8 +20,8 @@ class ScriptBadgeHandler : public ManifestHandler {

virtual ~ScriptBadgeHandler();

virtual bool Parse(Extension* extension, string16* error) OVERRIDE;

- virtual const std::vector<std::string>& PrerequisiteKeys() OVERRIDE;

- virtual bool AlwaysParseForType(Manifest::Type type) OVERRIDE;

+ virtual const std::vector<std::string> PrerequisiteKeys() const OVERRIDE;

+ virtual bool AlwaysParseForType(Manifest::Type type) const OVERRIDE;

private:

// Sets the fields of ActionInfo to the default values, matching the parent

@@ -29,7 +29,7 @@ class ScriptBadgeHandler : public ManifestHandler {

// is present in the manifest.

void SetActionInfoDefaults(const Extension* extension, ActionInfo* info);

- std::vector<std::string> prerequisite_keys_;

+ virtual const std::vector<std::string> Keys() const OVERRIDE;

DISALLOW_COPY_AND_ASSIGN(ScriptBadgeHandler);

};